Skip to content

Fix CI on FreeBSD 15 #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Jun 14, 2025

A recent change has replaced an unused preprocessor symbol: P_UNUSED3

freebsd/freebsd-src@33be163

Another recent change has changed the size of a spare field: mc_spare

freebsd/freebsd-src@eea3e4d

Description

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI will fail until #4489. Are you okay to backport this as well?

@asomers
Copy link
Contributor Author

asomers commented Jun 15, 2025

Backport to the 0.2 branch? Yes, that would be good.

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 15, 2025
A recent change has replaced an unused preprocessor symbol: P_UNUSED3

freebsd/freebsd-src@33be163

Another recent change has changed the size of a spare field: mc_spare

freebsd/freebsd-src@eea3e4d
@tgross35 tgross35 enabled auto-merge June 15, 2025 23:47
@tgross35 tgross35 disabled auto-merge June 16, 2025 00:05
@tgross35
Copy link
Contributor

I have absolutely no idea why small changes like this make ctest blow up, that library is insufferable and I can't wait until it's gone. I'm going to try to get things "fixed" a bit more before merging this so we don't lose all the FreeBSD CI jobs (#4469)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix O-x86 S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants