Update Redox SA_ constants. #4426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-redox
O-unix
S-waiting-on-review
stable-nominated
tgross35
requested changes
Apr 25, 2025
3 tasks
4lDO2
force-pushed
the
redox-signal-defs
branch
from
f1e5b6d to
74c3cc0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
(cherry picked from commit 74c3cc0) (backport <rust-lang#4426>)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
(cherry picked from commit 74c3cc0) (backport <rust-lang#4426>)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
(backport <rust-lang#4426>) (cherry picked from commit 74c3cc0)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
(backport <rust-lang#4426>) (cherry picked from commit 74c3cc0)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redox completely redesigned its signal handling code last summer, but this wasn't upstreamed to the libc crate, making crates like signal-hook segfault.
It would be appreciated if a 0.2 minor version could be released with these changes.
Closes: #4262
Sources
https://gitlab.redox-os.org/redox-os/relibc/-/blob/master/src/header/signal/redox.rs?ref_type=heads#L43-50
underlying diff
https://gitlab.redox-os.org/redox-os/relibc/-/merge_requests/480/diffs#d174caa1d6ee478ceffe421ab58c6f035a7e7285_72_39
Checklist
*LASTor*MAXareincluded
@rustbot label +stable-nominated