-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Introduce a new c_enum
macro
#4420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tgross35: no appropriate reviewer found, use |
Our current `e!` macro makes it easy to run into UB if C headers add a variant that isn't represented in the Rust version. Add a path to migrate away from this by introducing the `c_enum!` macro which represents a C enum as Rust constants and a type alias. Part of [1]. [1]: rust-lang#4419
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Our current `e!` macro makes it easy to run into UB if C headers add a variant that isn't represented in the Rust version. Add a path to migrate away from this by introducing the `c_enum!` macro which represents a C enum as Rust constants and a type alias. Part of [1]. [1]: rust-lang#4419 (cherry picked from commit 62051ca) (backport <rust-lang#4420>)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Our current `e!` macro makes it easy to run into UB if C headers add a variant that isn't represented in the Rust version. Add a path to migrate away from this by introducing the `c_enum!` macro which represents a C enum as Rust constants and a type alias. Part of [1]. [1]: rust-lang#4419 (cherry picked from commit 62051ca) (backport <rust-lang#4420>)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Our current `e!` macro makes it easy to run into UB if C headers add a variant that isn't represented in the Rust version. Add a path to migrate away from this by introducing the `c_enum!` macro which represents a C enum as Rust constants and a type alias. Part of [1]. [1]: rust-lang#4419 (backport <rust-lang#4420>) (cherry picked from commit 62051ca)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 28, 2025
Our current `e!` macro makes it easy to run into UB if C headers add a variant that isn't represented in the Rust version. Add a path to migrate away from this by introducing the `c_enum!` macro which represents a C enum as Rust constants and a type alias. Part of [1]. [1]: rust-lang#4419 (backport <rust-lang#4420>) (cherry picked from commit 62051ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current
e!
macro makes it easy to run into UB if C headers add a variant that isn't represented in the Rust version. Add a path to migrate away from this by introducing thec_enum!
macro which represents a C enum as Rust constants and a type alias.Part of 1.
@rustbot label +stable-nominated