Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_like: unify SIGEV_THREAD_ID support #3661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christoph-heiss
Copy link

This has been supported in musl since release v1.2.2 in January 2021. See also the commit in musl itself.

Not sure about emscripten though - I guess without gating it, it would be enabled there too?
As this is my first contribution, please just holler if something is off.

@rustbot
Copy link
Collaborator

rustbot commented Apr 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@christoph-heiss christoph-heiss force-pushed the musl-sigev-thread-id branch 3 times, most recently from 2fd26c6 to 1c292ff Compare April 18, 2024 15:36
@JohnTitor
Copy link
Member

(Should be merged after we upgrade musl header on CI).

@christoph-heiss
Copy link
Author

(Should be merged after we upgrade musl header on CI).

For reference, should be mergeable after this PR: #3068.

@tgross35
Copy link
Contributor

@rustbot blocked

This effectively adds the constant for musl too, as last platform of
this category.

It has been supported in musl since

  7c71792e ("add support for SIGEV_THREAD_ID timers")

and was released with v1.2.2 in January 2021.

Also double-checked that the `sigevent` struct is defined in the exact
same way.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
@tgross35 tgross35 added this to the 1.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants