-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken vita std compilation by adding SOMAXCONN #3538
Conversation
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
I don't think the ESP IDF's |
Interesting... I removed ESP's definition then, thanks! |
Could you rebase onto main to trigger full CI? |
Forgot to comment, but done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
std is broken on PS Vita since rust-lang/rust#119026
esp-idf's SOMAXCONN from https://github.com/espressif/esp-idf/blob/b3f7e2c8a4d354df8ef8558ea7caddc07283a57b/components/newlib/platform_include/net/if.h#L20(removed as it was probably incorrect, see comment)@ivmarkov can you confirm the esp change?