Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken vita std compilation by adding SOMAXCONN #3538

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

pheki
Copy link
Contributor

@pheki pheki commented Jan 11, 2024

std is broken on PS Vita since rust-lang/rust#119026

@ivmarkov can you confirm the esp change?

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2024

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@ivmarkov
Copy link
Contributor

std is broken on PS Vita since rust-lang/rust#119026

@ivmarkov can you confirm the esp change?

I don't think the ESP IDF's SOMAXCONN value of 128 is correct either, given that LwIP supports at most 10 to 16 sockets.
BUT: Not so important for ESP IDF really because
(a) I already PR-ed a fix to Rust STD for ESP IDF-specifically, which removes the SOMAXCONN usage; the PR was merged last week
(b) The breakage of STD is w.r.t. Unix domain sockets, which are not a thing on ESP IDF anyway and if the usert tries to use these, they would return a runtime error (we just wanted STD to compile)

@pheki
Copy link
Contributor Author

pheki commented Jan 12, 2024

I don't think the ESP IDF's SOMAXCONN value of 128 is correct either, given that LwIP supports at most 10 to 16 sockets.

Interesting... I removed ESP's definition then, thanks!

@JohnTitor
Copy link
Member

Could you rebase onto main to trigger full CI?

@pheki
Copy link
Contributor Author

pheki commented Jan 16, 2024

Could you rebase onto main to trigger full CI?

Forgot to comment, but done!

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor added this pull request to the merge queue Jan 18, 2024
Merged via the queue into rust-lang:main with commit 6ef94de Jan 18, 2024
42 checks passed
@tgross35 tgross35 added the stable-applied This PR has been cherry-picked to libc's stable release branch label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants