Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenHarmony #3138

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Add support for OpenHarmony #3138

merged 1 commit into from
Mar 5, 2023

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 4, 2023

This PR adds support for OpenHarmony targets:

  • aarch64-linux-ohos
  • arm-linux-ohos

Compiler team MCP: rust-lang/compiler-team#568

OpenHarmony uses a fork of musl with minor modifications, so most of the code is shared with other musl targets. Additionally, although OpenHarmony uses musl 1.2, it is still ABI-compatible with musl 1.1 so the existing bindings should continue to work until #3068 is merged.

A PR to add the targets to rustc will follow after this is merged.

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@notgull
Copy link
Contributor

notgull commented Mar 4, 2023

Out of curiosity, does OpenHarmony provide a new polling system, or does it just use Epoll like Linux does?

@Amanieu
Copy link
Member Author

Amanieu commented Mar 4, 2023

These OpenHarmony targets run on top of the Linux kernel and therefore support the same standard mechanisms that Linux provides. However OpenHarmony also supports running on embedded devices & microcontrollers with a custom kernel (LiteOS), but these targets are not currently supported in this PR.

@JohnTitor
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2023

📌 Commit 3f5128e has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 4, 2023

⌛ Testing commit 3f5128e with merge da4f8f8...

@bors
Copy link
Contributor

bors commented Mar 5, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing da4f8f8 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 5, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing da4f8f8 to master...

@bors
Copy link
Contributor

bors commented Mar 5, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit da4f8f8 into rust-lang:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants