Add getauxval for 64-bit Android #1991
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ |
|
📌 Commit 3635a90 has been approved by |
…id, r=JohnTitor Add getauxval for 64-bit Android Fixes #1987 This adds `getauxval` declaration on all 64-bit Android targets. This function was not declared in Bionic until API level 18. 64-bit support was added to Android in 5.0 (API level 21) thus all 64-bit targets (including AFAICT MIPS64 though I am not able to confirm this) should have `getauxval` declared. The `AT_` constants should be the same on all platforms.
|
💔 Test failed - checks-actions |
Spurious? @bors retry |
…id, r=JohnTitor Add getauxval for 64-bit Android Fixes #1987 This adds `getauxval` declaration on all 64-bit Android targets. This function was not declared in Bionic until API level 18. 64-bit support was added to Android in 5.0 (API level 21) thus all 64-bit targets (including AFAICT MIPS64 though I am not able to confirm this) should have `getauxval` declared. The `AT_` constants should be the same on all platforms.
|
💔 Test failed - checks-actions |
|
Ah, you should import header files here to pass the tests: Line 1473 in 70962e3 |
|
Should be ready for a retry |
|
Let's try with a new bors feature. @bors squash r+ |
|
📌 Commit 71bfcb8 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Fixes #1987
This adds
getauxvaldeclaration on all 64-bit Android targets. This function was not declared in Bionic until API level 18. 64-bit support was added to Android in 5.0 (API level 21) thus all 64-bit targets (including AFAICT MIPS64 though I am not able to confirm this) should havegetauxvaldeclared.The
AT_constants should be the same on all platforms.