Skip to content

Bors sometimes tests a different commit than what got approved #215

Open

Description

This looks like a race condition: In rust-lang/miri#3399, I did bors r+, then I did a force push, then the tests started.

Commit rust-lang/miri@9dfd214 has been approved by RalfJung

Testing commit rust-lang/miri@00f700d with merge rust-lang/miri@bf1e82f...

Note how it is testing a different commit than what got approved! No idea how that is possible, I thought it would store in a database "commit X got approved" and then it will only ever test that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions