Skip to content

Need prefix to PR number in merge commit message, otherwise incorrect linking occurs with subtrees #144

Open
@steffahn

Description

@steffahn

Looking at clippy commits in the rust repo, e.g. in PR rust-lang/rust#84980, you’ll see commit messages from @bors merge commits, e.g.

rust-lang/rust@ce37099

containing PR numbers from rust-lang/rust-clippy. But it’s just the number in a commit message, so github inserts a link to the same number in rust-lang/rust! So it links to the issue rust-lang/rust#7140 instead of the PR rust-lang/rust-clippy#7140. Look at that issue, github even inserted a back-link to the entirely unrelated bors commit.

I suggest changing the message of such a commit from

Auto merge of #7140

to

Auto merge of rust-lang/rust-clippy#7140

This way, linking works correctly. And it still doesn’t need a full URL. I double-checked that the linking works correctly here: steffahn/rust@b41e6a2.

I’m not sure how homu works, if this is something that needs to be changed here or just some configuration.

Also note that this is only strictly necessary for subtrees such as clippy or rustfmt, but I guess it wouldn’t hurt either if the prefixes were added in all repositories.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions