Fix leak of memory if dropping function panic #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like fail caused by rust-lang/rust#101474 as mentioned in #359 |
|
I'm concerned that this increases code size (and thus compilation time) for little benefit: a panic in a Drop usually means that you're going to leak memory anyways. IMO the proper solution is to completely disallow unwinding from Drop (rust-lang/rfcs#3288). |
Hmm... yes, I think you're right. Complications do not bring any benefit. Closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #348, but we are considering panic during table dropping. If the element from the
dropping tablepanics from itsDrop impl, the table will not be deallocated, leading to a memory leak. This pull request fixes that.