add apply sys api #531
Merged
add apply sys api #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems like enum flags need to be untyped (fix ci) trying to fix windows ci issue fix typo next try fixing windows warning next windows ci fix
|
Looks good to me, thanks! |
extrawurst
commented
Mar 20, 2020
| pub delta_cb: git_apply_delta_cb, | ||
| pub hunk_cb: git_apply_hunk_cb, | ||
| pub payload: *mut c_void, | ||
| pub flags: u32, |
There was a problem hiding this comment.
Hey @alexcrichton thanks for merging!
Out of curiosity: why is it not possible to idiomatically use the enum types in the structs? This only seemed to fail on windows:
https://github.com/rust-lang/git2-rs/runs/521702373
I see many structs using the u32 instead of the actual enum type, but some seem to be able to use them, what am I missing?
There was a problem hiding this comment.
I think it has to do with the way MSVC handles enums and whether they're signed or not. I don't remember a ton of specifics but I know it's slightly different from gcc which has caused issues. In any case I'm fine with tweaking things as necessary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing sys calls for missing
applyAPI. is it ok to split this from implementing a safe API or does it have to be in one PR?(this is related to #403)