Skip to content

Tracking issue for cargo fix --edition-idioms #165

Open
@carols10cents

Description

@carols10cents

https://github.com/rust-lang-nursery/edition-guide/blame/5f3cc2a5618700efcde3bc00799744f21fa9ad2e/src/editions/transitioning-an-existing-project-to-a-new-edition.md#L95-L106 says:

Eventually, we want cargo fix to fix all these idioms automatically in the same manner we did for upgrading to the 2018 edition. Currently, though, the "idiom lints" are not ready for widespread automatic fixing. The compiler isn't making cargo fix-compatible suggestions in many cases right now, and it is making incorrect suggestions in others. Enabling the idiom lints, even with cargo fix, is likely to leave your crate either broken or with many warnings still remaining.

We have plans to make these idiom migrations a seamless part of the Rust 2018 experience, but we're not there yet. As a result the following instructions are recommended only for the intrepid who are willing to work through a few compiler/Cargo bugs!

Further down in the same file, https://github.com/rust-lang-nursery/edition-guide/blame/5f3cc2a5618700efcde3bc00799744f21fa9ad2e/src/editions/transitioning-an-existing-project-to-a-new-edition.md#L128-L129

As mentioned before, there are known bugs around the idiom lints which
means they're not all ready for prime time yet.

Is this still the case? If so, what is blocking us from recommending that people run cargo fix --edition-idioms? That is, are there specific open issues that could be tracked here as blockers to removing these paragraphs?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions