Skip to content

yanks might get ignored when the build is still queued  #1934

Open

Description

So it's not forgotten I'll write down my findings here.

When we get a Yank change from crates-index-diff, we are running an UPDATE statement on the releases table.

We only add the release to that table after the build is finished, so when the release is still in our build-queue, or in progress, the yank wouldn't do anything.

Since we don't check the number of updated rows for that UPDATE statement, this also never lead to an error.

While we could solve this issue by storing the yank-state in the build-queue too, this could also be solved via solving #1011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-buildsArea: Building the documentation for a crateC-bugCategory: This is a bugE-easyEffort: Should be easy to implement and would make a good first PR

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions