Skip to content

Remove obsolete ember-cli-deprecation-workflow addon #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jul 12, 2024

We don't need this anymore, so we don't need to install it anymore either. Additionally, the new major version appears to unconditionally include the addon code in production builds too which is a price I'm not willing to pay.

Turbo87 added 2 commits July 12, 2024 10:56
… config

It looks like Ember Data has been fixed to no longer warn about this, so we can remove the deprecation silencing behavior.
We're currently not using this, so we don't need to install it anymore. Additionally, the new major version appears to unconditionally include the addon code in production builds too which is a price I'm not willing to pay.
@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Jul 12, 2024
@Turbo87 Turbo87 enabled auto-merge July 12, 2024 09:09
@Turbo87 Turbo87 merged commit be0105c into rust-lang:main Jul 12, 2024
9 checks passed
@Turbo87 Turbo87 deleted the dep-workflow branch July 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant