Switch to binary prefixes #7218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Rustin170506
reviewed
Oct 3, 2023
app/helpers/pretty-bytes.js
Outdated
| * See https://github.com/rust-lang/crates.io/discussions/7177 | ||
| * | ||
| * Here we set fraction digits to 1 because `cargo publish` | ||
| * uses this format (see https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/cargo_package.rs#L168-L171) |
There was a problem hiding this comment.
Could you please use a tag instead of the master branch here?
Using a fixed version can make sure we can always find it.
There was a problem hiding this comment.
Thanks, I see! I'll fix them...
Turbo87
reviewed
Oct 3, 2023
Turbo87
reviewed
Oct 3, 2023
|
thanks :) |
Andrew15-5
reviewed
Oct 3, 2023
Comment on lines
+9
to
+12
| prettyBytes(bytes, { | ||
| binary: true, | ||
| ...options, | ||
| }), |
There was a problem hiding this comment.
@Turbo87, what's the point of "making it possible to override these defaults", if it is never (AFAIU) overridden anywhere?
In #7177 (comment) I intentionally wrote {...options, binary: true} so that binary prefixes will be anywhere and everywhere (that was the point from the start).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from
and changes the unit of package size to use binary prefixes as shown in test cases in
tests/unit/helpers/pretty-bytes-test.js.