Add Categorization! #473
Add Categorization! #473
Commits on Dec 28, 2016
-
-
-
-
-
I like when they match up with the filenames :)
-
Extract a method for encoding a crate without all its metadata
I draw the line at 3 None arguments.
-
-
-
-
-
-
-
Use a pretty slug for categories in URLs
Categories are now specified by slug in Cargo.toml. This will allow crates.io to change the display text of a category but still have crates in those categories. Characters allowed in slugs are from RFC 3986, those that are valid in path segments (pchar) https://tools.ietf.org/html/rfc3986#page-22
-
Change the header text on a category page
Looking at some of the categories I have locally, I think, for example, "Command-line argument parsing Crates" is clearer than "All Crates for category 'Command-line argument parsing'"
-
-
-
-
-
-
-
Add a page listing all valid category slugs
To direct people to when they have specified an invalid slug. JSON containing all the slugs is available at /api/v1/category_slugs, but visiting that in a browser doesn't work.
-
Make warnings about invalid crate names be JSON instead of text
And cargo will handle making nice English messages out of them.
-
-
Add descriptions to categories
Have to switch from a nice batch insert to running a query for each category so that we can use apostrophes in the descriptions and have the string escaped for SQL.
-
-
Fix the query for subcategories to only include the next level
And not all descendant categories
-
Add a heading for Crates on a category page
To better distinguish subcategories and crates. This makes "crates" in the h1 redundant, especially when there *aren't* subcategories.
-
Sort crates within a category by downloads by default
There will be an RFC soon about whether this is the best ordering or not.
-
Sum crate count in all subcategories in a better way
And make the top-level query that does this consistent with subcategory queries.
-
-
Use a different crate name in a test to prevent deadlocks
This test does a lot of different manipulations of categories and crate categories and it was using a crate named foo. The good_categories test also used a crate named foo, and these two tests were causing a postgres deadlock. I was able to cause deadlocks more often by duplicating the update_crate test and the good_categories test: https://travis-ci.org/integer32llc/crates.io/builds/187302718 Making this change and running the duplicated tests resulted in 0 deadlocks: https://travis-ci.org/integer32llc/crates.io/builds/187306433 This is unlikely to happen in production; requests get a database connection that gets closed when the request finishes, and the publish request only modifies the categories once, not as much as the update_crate test is. It seems unlikely that two people would publish the same crate at exactly the same time.
