Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow feature names to begin with numbers #1331

Merged
merged 2 commits into from
Apr 9, 2018

Commits on Apr 7, 2018

  1. Allow feature names to begin with numbers

    Diesel 1.2 had planned on renaming our `large-tables` and `huge-tables`
    features to `32-column-tables` and `64-column-tables` respectively,
    while also introducing the `128-column-tables` feature. This change was
    made several months ago in Diesel. Cargo will happily accept those
    as feature names, and resolve them properly from other crates.
    
    However while publishing Diesel 1.2, I ran into a snag mid-release when
    I realized that Cargo is incorrectly assuming that a feature name must
    be the same as a crate name. I suspect this is an artifact of the fact
    that feature names often are crate names (and perhaps in the past that
    was the only form of feature?).
    
    However, now they are an entirely separate thing, and we should allow
    the same set of feature names that Cargo does. (As an aside, do we want
    to apply the same 64 character limit that we apply to crate names to
    feature names?)
    
    Fixes rust-lang#1329.
    sgrif committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    4bf9efa View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. Configuration menu
    Copy the full SHA
    cd8be67 View commit details
    Browse the repository at this point in the history