msw/tests: Replace assert with expect (#12522)

see https://vitest.dev/api/expect.html and https://vitest.dev/api/assert.html

Author: Turbo87

packages/crates-io-msw/handlers/api-tokens/create.test.js

@@ -1,4 +1,4 @@
-import { afterEach, assert, beforeEach, test, vi } from 'vitest';
+import { afterEach, beforeEach, expect, test, vi } from 'vitest';
 
 import { db } from '../../index.js';
 
@@ -17,12 +17,12 @@ test('creates a new API token', async function () {
 
   let body = JSON.stringify({ api_token: { name: 'foooo' } });
   let response = await fetch('/api/v1/me/tokens', { method: 'PUT', body });
-  assert.strictEqual(response.status, 200);
+  expect(response.status).toBe(200);
 
   let token = db.apiToken.findMany(null)[0];
-  assert.ok(token);
+  expect(token).toBeTruthy();
 
-  assert.deepEqual(await response.json(), {
+  expect(await response.json()).toEqual({
     api_token: {
       id: 1,
       crate_scopes: null,
@@ -49,12 +49,12 @@ test('creates a new API token with scopes', async function () {
     },
   });
   let response = await fetch('/api/v1/me/tokens', { method: 'PUT', body });
-  assert.strictEqual(response.status, 200);
+  expect(response.status).toBe(200);
 
   let token = db.apiToken.findMany(null)[0];
-  assert.ok(token);
+  expect(token).toBeTruthy();
 
-  assert.deepEqual(await response.json(), {
+  expect(await response.json()).toEqual({
     api_token: {
       id: 1,
       crate_scopes: ['serde', 'serde-*'],
@@ -80,12 +80,12 @@ test('creates a new API token with expiry date', async function () {
     },
   });
   let response = await fetch('/api/v1/me/tokens', { method: 'PUT', body });
-  assert.strictEqual(response.status, 200);
+  expect(response.status).toBe(200);
 
   let token = db.apiToken.findMany(null)[0];
-  assert.ok(token);
+  expect(token).toBeTruthy();
 
-  assert.deepEqual(await response.json(), {
+  expect(await response.json()).toEqual({
     api_token: {
       id: 1,
       crate_scopes: null,
@@ -103,8 +103,8 @@ test('creates a new API token with expiry date', async function () {
 test('returns an error if unauthenticated', async function () {
   let body = JSON.stringify({ api_token: {} });
   let response = await fetch('/api/v1/me/tokens', { method: 'PUT', body });
-  assert.strictEqual(response.status, 403);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(403);
+  expect(await response.json()).toEqual({
     errors: [{ detail: 'must be logged in to perform that action' }],
   });
 });

packages/crates-io-msw/handlers/api-tokens/delete.test.js

@@ -1,4 +1,4 @@
-import { assert, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 import { db } from '../../index.js';
 
@@ -9,20 +9,20 @@ test('revokes an API token', async function () {
   let token = await db.apiToken.create({ user });
 
   let response = await fetch(`/api/v1/me/tokens/${token.id}`, { method: 'DELETE' });
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {});
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({});
 
   let tokens = db.apiToken.findMany(null);
-  assert.strictEqual(tokens.length, 0);
+  expect(tokens.length).toBe(0);
 });
 
 test('returns an error if unauthenticated', async function () {
   let user = await db.user.create();
   let token = await db.apiToken.create({ user });
 
   let response = await fetch(`/api/v1/me/tokens/${token.id}`, { method: 'DELETE' });
-  assert.strictEqual(response.status, 403);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(403);
+  expect(await response.json()).toEqual({
     errors: [{ detail: 'must be logged in to perform that action' }],
   });
 });

packages/crates-io-msw/handlers/api-tokens/get.test.js

@@ -1,4 +1,4 @@
-import { assert, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 import { db } from '../../index.js';
 
@@ -13,8 +13,8 @@ test('returns the requested token', async function () {
   });
 
   let response = await fetch(`/api/v1/me/tokens/${token.id}`);
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     api_token: {
       id: 1,
       crate_scopes: ['serde', 'serde-*'],
@@ -32,14 +32,14 @@ test('returns 404 if token not found', async function () {
   await db.mswSession.create({ user });
 
   let response = await fetch('/api/v1/me/tokens/42');
-  assert.strictEqual(response.status, 404);
-  assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] });
+  expect(response.status).toBe(404);
+  expect(await response.json()).toEqual({ errors: [{ detail: 'Not Found' }] });
 });
 
 test('returns an error if unauthenticated', async function () {
   let response = await fetch('/api/v1/me/tokens/42');
-  assert.strictEqual(response.status, 403);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(403);
+  expect(await response.json()).toEqual({
     errors: [{ detail: 'must be logged in to perform that action' }],
   });
 });

packages/crates-io-msw/handlers/api-tokens/list.test.js

@@ -1,4 +1,4 @@
-import { afterEach, assert, beforeEach, test, vi } from 'vitest';
+import { afterEach, beforeEach, expect, test, vi } from 'vitest';
 
 import { db } from '../../index.js';
 
@@ -26,8 +26,8 @@ test('returns the list of API token for the authenticated `user`', async functio
   await db.apiToken.create({ user, createdAt: '2017-11-19T15:59:22Z', expiredAt: '2017-11-20T10:59:22Z' });
 
   let response = await fetch('/api/v1/me/tokens');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     api_tokens: [
       {
         id: 3,
@@ -65,14 +65,14 @@ test('empty list case', async function () {
   await db.mswSession.create({ user });
 
   let response = await fetch('/api/v1/me/tokens');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), { api_tokens: [] });
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({ api_tokens: [] });
 });
 
 test('returns an error if unauthenticated', async function () {
   let response = await fetch('/api/v1/me/tokens');
-  assert.strictEqual(response.status, 403);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(403);
+  expect(await response.json()).toEqual({
     errors: [{ detail: 'must be logged in to perform that action' }],
   });
 });

packages/crates-io-msw/handlers/categories/get.test.js

@@ -1,11 +1,11 @@
-import { assert, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 import { db } from '../../index.js';
 
 test('returns 404 for unknown categories', async function () {
   let response = await fetch('/api/v1/categories/foo');
-  assert.strictEqual(response.status, 404);
-  assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] });
+  expect(response.status).toBe(404);
+  expect(await response.json()).toEqual({ errors: [{ detail: 'Not Found' }] });
 });
 
 test('returns a category object for known categories', async function () {
@@ -15,8 +15,8 @@ test('returns a category object for known categories', async function () {
   });
 
   let response = await fetch('/api/v1/categories/no-std');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     category: {
       id: 'no-std',
       category: 'no-std',
@@ -35,8 +35,8 @@ test('calculates `crates_cnt` correctly', async function () {
   await Promise.all(Array.from({ length: 3 }, () => db.crate.create({ categories: [notTestCli] })));
 
   let response = await fetch('/api/v1/categories/test-cli-category');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     category: {
       category: 'test-cli-category',
       crates_cnt: 7,

packages/crates-io-msw/handlers/categories/list-slugs.test.js

@@ -1,11 +1,11 @@
-import { assert, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 import { db } from '../../index.js';
 
 test('empty case', async function () {
   let response = await fetch('/api/v1/category_slugs');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     category_slugs: [],
   });
 });
@@ -18,8 +18,8 @@ test('returns a category slugs list', async function () {
   await Promise.all(Array.from({ length: 2 }, () => db.category.create()));
 
   let response = await fetch('/api/v1/category_slugs');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     category_slugs: [
       {
         description: 'This is the description for the category called "Category 2"',
@@ -44,6 +44,6 @@ test('has no pagination', async function () {
   await Promise.all(Array.from({ length: 25 }, () => db.category.create()));
 
   let response = await fetch('/api/v1/category_slugs');
-  assert.strictEqual(response.status, 200);
-  assert.strictEqual((await response.json()).category_slugs.length, 25);
+  expect(response.status).toBe(200);
+  expect((await response.json()).category_slugs.length).toBe(25);
 });

packages/crates-io-msw/handlers/categories/list.test.js

@@ -1,11 +1,11 @@
-import { assert, test } from 'vitest';
+import { expect, test } from 'vitest';
 
 import { db } from '../../index.js';
 
 test('empty case', async function () {
   let response = await fetch('/api/v1/categories');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     categories: [],
     meta: {
       total: 0,
@@ -21,8 +21,8 @@ test('returns a paginated categories list', async function () {
   await Promise.all(Array.from({ length: 2 }, () => db.category.create()));
 
   let response = await fetch('/api/v1/categories');
-  assert.strictEqual(response.status, 200);
-  assert.deepEqual(await response.json(), {
+  expect(response.status).toBe(200);
+  expect(await response.json()).toEqual({
     categories: [
       {
         id: 'category-2',
@@ -59,11 +59,11 @@ test('never returns more than 10 results', async function () {
   await Promise.all(Array.from({ length: 25 }, () => db.category.create()));
 
   let response = await fetch('/api/v1/categories');
-  assert.strictEqual(response.status, 200);
+  expect(response.status).toBe(200);
 
   let responsePayload = await response.json();
-  assert.strictEqual(responsePayload.categories.length, 10);
-  assert.strictEqual(responsePayload.meta.total, 25);
+  expect(responsePayload.categories.length).toBe(10);
+  expect(responsePayload.meta.total).toBe(25);
 });
 
 test('supports `page` and `per_page` parameters', async function () {
@@ -76,13 +76,10 @@ test('supports `page` and `per_page` parameters', async function () {
   );
 
   let response = await fetch('/api/v1/categories?page=2&per_page=5');
-  assert.strictEqual(response.status, 200);
+  expect(response.status).toBe(200);
 
   let responsePayload = await response.json();
-  assert.strictEqual(responsePayload.categories.length, 5);
-  assert.deepEqual(
-    responsePayload.categories.map(it => it.id),
-    ['cat-06', 'cat-07', 'cat-08', 'cat-09', 'cat-10'],
-  );
-  assert.strictEqual(responsePayload.meta.total, 25);
+  expect(responsePayload.categories.length).toBe(5);
+  expect(responsePayload.categories.map(it => it.id)).toEqual(['cat-06', 'cat-07', 'cat-08', 'cat-09', 'cat-10']);
+  expect(responsePayload.meta.total).toBe(25);
 });