Skip to content

Commit 216f726

Browse files
committed
Run cargo clean on CI when the version of rustc changes
Recently I've been monitoring where our CI time is spent. Currently, the build and test stages take about 14 minutes without a cache and 1.7 to 3.6 minutes when a cache is present. The variation in the latter comes from the `cargo install diesel_cli` step which is partially rebuilt any time a new compatible version of a dependency is published. For each channel, we cache about 1GB of build artifacts. This results in a total of 4 minutes that are spent in caching related activities. However, extracting the cache on Travis appears to be O(n^3) because once a new version of rustc is released the size of the `target/` directory doubles but cache extraction take 8 times as long and total cache related time nearly quadruples to 13.5 minutes. This effectively wipes out any gains of caching build artifacts for our codebase, especially on the beta and nightly channels. This commit adds a shell script that is run before any build steps on CI. The script works by recording the version of rustc in a file under `target/`. Upon the next build, if the cache was created by the same version of rustc then no action is taken. However, if the version of rustc has changed then `cargo clean` is run to clear out the stale cached files. This commit also sets the cache timeout (for building and uploading the cache) to 6 minutes. The default is 3 minutes and this portion is currently taking about 2.6 minutes. The rationale here is to provide some additional headroom on the stable channel. As dependencies are updated, the cache will gradually grow until a new release causes the cache to be cleared. The increased timeout should allow for this natural growth while also enforcing a reasonable limit so that caching overhead doesn’t grow too large.
1 parent 614b33c commit 216f726

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

.travis.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ cache:
1111
cargo: true
1212
directories:
1313
- $HOME/.npm
14-
timeout: 600
14+
# Set timeout to 6 minutes (double the default of 3 minutes)
15+
timeout: 360
1516

1617
env:
1718
global:
@@ -26,6 +27,7 @@ env:
2627
- PERCY_PROJECT=crates-io/crates.io
2728

2829
install:
30+
- script/cargo-clean-on-new-rustc-version.sh
2931
- cargo install --force diesel_cli --vers `cat .diesel_version` --no-default-features --features postgres && export PATH=$HOME/.cargo/bin:$PATH
3032

3133
before_script:
@@ -68,9 +70,6 @@ matrix:
6870
script:
6971
- cargo build
7072
- cargo test
71-
# This portion of the cache is quickly invalidated anyway
72-
before_cache:
73-
- cargo clean
7473

7574
notifications:
7675
email:
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
#!/bin/sh
2+
3+
set -e
4+
5+
stamp_file=target/rustc_version_stamp
6+
current_version=$(rustc --version)
7+
8+
if [ -f $stamp_file ]; then
9+
# Compare the current version against the previous version
10+
if echo "$current_version" | cmp -s $stamp_file -; then
11+
echo "Version of rustc hasn't changed, keeping the cache intact"
12+
else
13+
echo "The version of rustc has changed, running cargo clean"
14+
cargo clean
15+
fi
16+
else
17+
echo "There is no existing version stamp, keeping the cache intact"
18+
fi
19+
20+
# Save the version stamp for next time
21+
mkdir -p target/
22+
echo $current_version > $stamp_file

0 commit comments

Comments
 (0)