Avoid panicking on negative durations #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 3, 2023
Avoid panicking on negative durations This currently causes a panic when loading a run's details page after it has finished the initial processing (but not yet completed log uploads, I think?).
|
💔 Test failed - checks-actions |
Mark-Simulacrum
force-pushed
the
skip-panic
branch
from
ea9341f to
7379810
Compare
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 3, 2023
Avoid panicking on negative durations This currently causes a panic when loading a run's details page after it has finished the initial processing (but not yet completed log uploads, I think?).
|
💔 Test failed - checks-actions |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 3, 2023
Avoid panicking on negative durations This currently causes a panic when loading a run's details page after it has finished the initial processing (but not yet completed log uploads, I think?).
|
💔 Test failed - checks-actions |
|
OK -- I think the CI failure here is because of -Zno-index-update, which is incompatible with the sparse index. It used to be that a single index fetch was enough, because it contained all crates, but that's no longer true. I'm not sure yet if we should just stop passing it or instead configure Cargo to use the git index. |
This breaks with the sparse index being on by default. The right fix might be to configure Cargo to continue using the git index, but it's not super clear and potentially with the sparse index the fetches will be fast enough that we don't need to worry that much.
Mark-Simulacrum
force-pushed
the
skip-panic
branch
from
8b3f059 to
2f13d9f
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently causes a panic when loading a run's details page after it has finished the initial processing (but not yet completed log uploads, I think?).