Update URL to get rust builds from new url #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I think this should work, but we could also just remove all of the |
|
This is a patch that successfully did a crater run so I have reasonable confidence it works :) A rethinking of the way crater retrieves rustc might be in order at some point though, good point. |
|
Yes, I am happy to merge now if we want. I think the future lies in a rustup library of some sort, but that's a separate discussion. |
aidanhs
force-pushed
the
aphs-new-s3-builds-url
branch
2 times, most recently
from
21b47f7 to
9f346fb
Compare
aidanhs
force-pushed
the
aphs-new-s3-builds-url
branch
from
9f346fb to
b9fdc47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed in rust-lang/rust#46354