Skip to content

Rename wasm32-wasi target to wasm32-wasi-preview1 #607

Closed
@yoshuawuyts

Description

Proposal

This is a sibling MCP to: "New tier-2 target for wasm32-wasi-preview2" MCP. During the conversation on Zulip it came up that if we're going to be introducing wasm32-wasi-preview2, we should probably also rename the existing wasm32-wasi target to wasm32-wasi-preview1 in order to accurately set expectations. This is because eventually we'll want to deprecate the preview1 target, so it's probably best if we start communicating that in the name. Additionally we would also rename the wasm32-wasi-threads target to wasm32-wasi-preview1-threads.

Because we are not (yet) removing a target but only renaming it, we should be able to do this over a regular Rust release. This means we are not going to have a period where thewasm32-wasi and wasm32-wasi-preview1 targets are both available in the toolchain. In order to facilitate a smoother transition however, we may want to look into teaching the toolchain manager about "deprecated targets", so a better error can be issued for people looking to upgrade to a new Rust version where a target has been renamed or removed.

Mentors or Reviewers

N/A

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions