Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the use of public_test_dep! #656

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 4, 2024

Replace public_test_dep! by placing optionally public items into new modules, then controlling what is exported with the public-test-deps feature.

This is nicer for automatic formatting and diagnostics.

@tgross35
Copy link
Contributor Author

tgross35 commented Aug 4, 2024

Some CI will fail until parts of #652 land.

Replace `public_test_dep!` by placing optionally public items into new
modules, then controlling what is exported with the `public-test-deps`
feature.

This is nicer for automatic formatting and diagnostics.
@Amanieu Amanieu merged commit 6736513 into rust-lang:master Aug 6, 2024
24 checks passed
@tgross35 tgross35 deleted the public-test-deps branch August 6, 2024 21:50
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 7, 2024

It looks like this created some surprising inference at rust-lang/rust#128691 (comment). I don't really understand why, asked on Zulip https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Associated.20type.20suggestions.

The other change is more pressing to get into the main repo, so I am just going to revert this and revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants