Skip to content

Commit

Permalink
Merge pull request #698 from tgross35/skip-asm-checks-fixme
Browse files Browse the repository at this point in the history
Ungate tests that were skipped due to a broken implementation
  • Loading branch information
tgross35 authored Sep 28, 2024
2 parents d5ca981 + 03f0916 commit 5d68310
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions testcrate/src/bench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,9 @@ pub fn skip_sys_checks(test_name: &str) -> bool {

/// Still run benchmarks/tests but don't check correctness between compiler-builtins and
/// assembly functions
pub fn skip_asm_checks(test_name: &str) -> bool {
// FIXME(f16_f128): rounding error
// <https://github.com/rust-lang/compiler-builtins/issues/616>
const SKIPPED: &[&str] = &["mul_f32", "mul_f64"];

SKIPPED.contains(&test_name)
pub fn skip_asm_checks(_test_name: &str) -> bool {
// Nothing to skip at this time
false
}

/// Create a comparison of the system symbol, compiler_builtins, and optionally handwritten
Expand Down

0 comments on commit 5d68310

Please sign in to comment.