Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap Windows targets triples to their LLVM counterparts #1176

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Remap Windows targets triples to their LLVM counterparts #1176

merged 1 commit into from
Aug 11, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 10, 2024 •
edited
Loading

Fixes #1167

@mati865 mati865 force-pushed the gnullvm-llvm19 branch 2 times, most recently from 436d9e4 to b6c01c9 Compare August 10, 2024 10:47
NobodyXu
NobodyXu requested changes Aug 10, 2024
View reviewed changes
src/target_info.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@mati865 mati865 mentioned this pull request Aug 10, 2024
Closed
@mati865 mati865 mentioned this pull request Aug 10, 2024
Merged
kleisauke added a commit to libvips/build-win64-mxe that referenced this pull request Aug 10, 2024
@kleisauke
Test build for rust-lang/cc-rs#1176
5b050d1
@mati865 mati865 marked this pull request as ready for review August 10, 2024 14:19
NobodyXu
NobodyXu approved these changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@NobodyXu NobodyXu merged commit 1c10013 into rust-lang:main Aug 11, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Aug 11, 2024
Merged
@mati865 mati865 deleted the gnullvm-llvm19 branch August 11, 2024 10:43
@BtbN BtbN mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblabla roblabla roblabla left review comments

@ChrisDenton ChrisDenton ChrisDenton left review comments

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failure on LLVM 19 with *-gnullvm
4 participants
@mati865 @roblabla @ChrisDenton @NobodyXu