Add support for workspace.metadata table
#8323
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks for this! I think it's fine to not parse the values here, though, and probably treat this the same way as |
|
@alexcrichton I think it is necessary to load it for the |
|
☔ The latest upstream changes (presumably #8321) made this pull request unmergeable. Please resolve the merge conflicts. |
Reword the documentation for the two `metadata` tables, and suggest consistent usage.
naerbnic
force-pushed
the
add_workspace_metadata_table
branch
from
2d095a5 to
341d416
Compare
|
Resolved and pushed |
|
Will there be a mechanism to get access to |
To my understanding, this should still be available through the |
|
Oh, I see, thanks. One observation - assuming I understand this, a crate downloaded by cargo as part of the build will not have access to the workspace metadata that it had in it's original source tree since it is no longer in a workspace. The [workspace|package].metadata is primarily aimed at tooling rather than build.rs I guess, so what I'm talking about here seems out of scope. Thanks again for your help. |
|
@rfcbot fcp merge |
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
rfcbot
added
the
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
Remove anchor to use the mdbook generated link instead. Co-authored-by: Eric Huss <eric@huss.org>
Add a link to the mdbook generated link Co-authored-by: Eric Huss <eric@huss.org>
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
rfcbot
removed
the
final-comment-period
|
@bors: r+ |
|
📌 Commit 16f3b8d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Update cargo 9 commits in 089cbb80b73ba242efdcf5430e89f63fa3b5328d..c26576f9adddd254b3dd63aecba176434290a9f6 2020-06-15 14:38:34 +0000 to 2020-06-23 16:21:21 +0000 - Adding environment variable CARGO_PKG_LICENSE_FILE (rust-lang/cargo#8387) - Enable "--target-dir" in "cargo install" (rust-lang/cargo#8391) - Add support for `workspace.metadata` table (rust-lang/cargo#8323) - Fix overzealous `clean -p` for reserved names. (rust-lang/cargo#8398) - Fix order-dependent feature resolution. (rust-lang/cargo#8395) - Correct mispelling of `cargo`. (rust-lang/cargo#8389) - Add missing license field. (rust-lang/cargo#8386) - Adding environment variable CARGO_PKG_LICENSE (rust-lang/cargo#8325) - Cut down on data fetch from git dependencies (rust-lang/cargo#8363)
Update metadata man page. The man pages needed to be rebuilt after #8323.
Implements feature request #8309
Additionally includes the information in the output of "cargo metadata" through a new top-level field
metadata, similar to the per-packagemetadatafield