Modify test to make rustc PR mergeable
#7883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
ehuss
reviewed
Feb 12, 2020
tests/testsuite/check.rs
Outdated
| @@ -64,7 +64,7 @@ fn check_fail() { | |||
|
|
|||
| foo.cargo("check") | |||
| .with_status(101) | |||
| .with_stderr_contains("[..]this function takes 0 parameters but 1 parameter was supplied") | |||
| .with_stderr_contains("[..]this function takes 0") | |||
There was a problem hiding this comment.
Suggested change
| .with_stderr_contains("[..]this function takes 0") | |
| .with_stderr_contains("[..]this function takes 0[..]") |
It has to match an entire line.
Modify a test to be less succeptible to failure for wording changes.
estebank
force-pushed
the
change-test
branch
from
c2a9c92
to
e0787ec
Compare
|
@bors r+ |
|
📌 Commit e0787ec has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 12, 2020
Modify test to make `rustc` PR mergeable Modify a test to be less succeptible to failure for wording changes.
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 19, 2020
Update cargo 9 commits in 3c53211c3d7fee4f430f170115af5baad17a3da9..e02974078a692d7484f510eaec0e88d1b6cc0203 2020-02-07 15:35:03 +0000 to 2020-02-18 15:24:43 +0000 - Set an environment variable for tests to find executables. (rust-lang/cargo#7697) - Rework internal errors. (rust-lang/cargo#7896) - Improvements to StringList config handling. (rust-lang/cargo#7891) - Add new/old rustflags to fingerprint log. (rust-lang/cargo#7890) - Fix inaccurate doc comment on `env_args`. (rust-lang/cargo#7889) - Add some extra fingerprint debug information. (rust-lang/cargo#7888) - Link the licenses into crates/cargo-platform (rust-lang/cargo#7886) - Modify test to make `rustc` PR mergeable (rust-lang/cargo#7883) - Keep environment variables in a BTreeMap to preserve sort order (rust-lang/cargo#7877)
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Mar 16, 2020
Modify test to make `rustc` PR mergeable Modify a test to be less succeptible to failure for wording changes.
bors
added a commit
that referenced
this pull request
Mar 17, 2020
Bump stable version to 0.43.1 There was a hiccup where 0.43.0 was published to crates.io missing a change (#7848), see #7994 for details. It is not super critical, but in rare cases the bug can cause cargo used as a library to hang. I think bumping the version and re-publishing is relatively low-effort and low-risk. This also includes backports to appease CI: #7883 #7906 #7955.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify a test to be less succeptible to failure for wording changes.