When running cargo package -l do not check for dependencies
#6729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense and is also fixing problem when one overrides crates.io registry with a folder and optional dependencies are missing. Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Could you try to capture the behaviour change in a test, please? |
|
In addition to what @dwijnand mentioned, could the call to |
ehuss
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #6840) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm gonna close this to help clear out the queue and it's been inactive for some time now, but it can of course be resubmitted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense and is also fixing problem when one overrides
crates.io registry with a folder and optional dependencies are missing.
Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com