Fixed some variables being unnecessarily mutable #4384
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -12,7 +12,7 @@ mod imp { | |||
|
|
|||
| pub fn read2(mut out_pipe: ChildStdout, | |||
| mut err_pipe: ChildStderr, | |||
| mut data: &mut FnMut(bool, &mut Vec<u8>, bool)) -> io::Result<()> { | |||
| data: &mut FnMut(bool, &mut Vec<u8>, bool)) -> io::Result<()> { | |||
There was a problem hiding this comment.
There's one more in #[cfg(windows)].
|
@bors: r+ Nice! |
|
📌 Commit 1486f42 has been approved by |
Fixed some variables being unnecessarily mutable ### Changes Some variables are marked `mut` when they don't need to be. This PR changes those variables to no longer be `mut`. ### Context PR on rust-lang/rust#43582 tl:dr; There's a bug with the mutability checker that sometimes marks mutable ref variables as being used when they're not.
|
☀️ Test successful - status-appveyor, status-travis |
Changes
Some variables are marked
mutwhen they don't need to be. This PR changes those variables to no longer bemut.Context
PR on rust-lang/rust#43582
tl:dr; There's a bug with the mutability checker that sometimes marks mutable ref variables as being used when they're not.