Fix a serialization error on publish #4085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ @alexcrichton You've said you've run the original code in the rewriting PR on tons of crates. If you have an infra for that left somewhere, it might be useful to do the same again, with the new implementation. |
|
CI failure seems legit. |
|
@bors r- |
In TOML we have to emit all keys before we emit all sub-tables, so to handle that for dependencies just transform everything to an elaborated version. Closes rust-lang#4081
|
📌 Commit d1e70e4 has been approved by |
bors
added a commit
that referenced
this pull request
May 22, 2017
Fix a serialization error on publish In TOML we have to emit all keys before we emit all sub-tables, so to handle that for dependencies just transform everything to an elaborated version. Closes #4081
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TOML we have to emit all keys before we emit all sub-tables, so to handle
that for dependencies just transform everything to an elaborated version.
Closes #4081