Skip to content

[beta-1.88] fix(rustc): Don't panic on unknown bins #15515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

[beta-1.88] fix(rustc): Don't panic on unknown bins #15515

merged 1 commit into from
May 10, 2025

Conversation

weihanglo
Copy link
Member

Beta backports

In order to make CI pass, the following PRs are also cherry-picked:

This was my fault that missed the merge window…

@weihanglo
fix(rustc): Don't panic on unknown bins (rust-lang#15497)
6b7976e 
### What does this PR try to resolve?

Fixes rust-lang#15493

### How should we test and review this PR?
This takes the most surgical, direct route to addressing the problem.
Alternatively, we could look into why `cargo rustc` and `cargo check`
are different.

### Additional information
@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.88.0. Please double check that you specified the right target!

@epage epage merged commit 873a064 into rust-lang:rust-1.88.0 May 10, 2025
23 checks passed
@weihanglo weihanglo deleted the beta-backport branch May 10, 2025 12:04
@weihanglo weihanglo mentioned this pull request May 10, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2025
@bors
Auto merge of rust-lang#140897 - weihanglo:update-beta-cargo, r=weiha…
1960d28 
…nglo

[beta-1.88] Update cargo

1 commits in 7918c7eb59614c39f1c4e27e99d557720976bdd7..873a0649350c486caf67be772828a4f36bb4734c
2025-04-27 09:44:23 +0000 to 2025-05-10 06:10:32 -0500
- [beta-1.88] fix(rustc): Don't panic on unknown bins (rust-lang/cargo#15515)

r? ghost
@rustbot rustbot added this to the 1.88.0 milestone May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees

@epage epage

Labels
A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
3 participants
@weihanglo @rustbot @epage