Skip to content

Loosen the dependency versions in Cargo.toml #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from May 3, 2015
Merged

Loosen the dependency versions in Cargo.toml #1551

merged 1 commit into from May 3, 2015

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2015

I don't think they were ever intended to be specific to the patch version but were accidentally made so in a1faa7c.

This upgrades docopt.rs to a version that supports typo suggestions for flags:

$ cargo build --jobz 64
Unknown flag: '--jobz'. Did you mean '--jobs'?

Closes #1546.

@rust-highfive
Copy link

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw
Copy link
Member

huonw commented Apr 27, 2015

I was under the impression that a 0.x.y dependency is satisfied by any 0.x.z with z >= y.

@alexcrichton
Copy link
Member

@bors: r+ eff8491

I agree with @huonw that the tweaks to Cargo.toml aren't strictly necessary, but it's fine to have them anyway!

@bors
Copy link
Contributor

bors commented Apr 27, 2015

⌛ Testing commit eff8491 with merge 6ed7ec9...

@bors
Copy link
Contributor

bors commented Apr 27, 2015

💔 Test failed - cargo-win-64

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Apr 27, 2015 at 12:01 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - cargo-win-64
http://buildbot.rust-lang.org/builders/cargo-win-64/builds/621


Reply to this email directly or view it on GitHub
#1551 (comment).

@bors
Copy link
Contributor

bors commented Apr 27, 2015

⌛ Testing commit eff8491 with merge f0df3d4...

bors added a commit that referenced this pull request Apr 27, 2015
I don't think they were ever intended to be specific to the patch version but were accidentally made so in a1faa7c.

This upgrades `docopt.rs` to a version that supports typo suggestions for flags:

```
$ cargo build --jobz 64
Unknown flag: '--jobz'. Did you mean '--jobs'?
```

Closes #1546.
@bors
Copy link
Contributor

bors commented Apr 27, 2015

💔 Test failed - cargo-win-64

@alexcrichton
Copy link
Member

Unfortunately it looks like we can't upgrade Rust just yet due to a recently introduced bug in process spawning: rust-lang/rust#24873

@ghost
Copy link
Author

ghost commented Apr 27, 2015

@alexcrichton I see, thanks for investigating!

@bors
Copy link
Contributor

bors commented Apr 30, 2015

☔ The latest upstream changes (presumably #1564) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Ok I picked up a bunch of updates as part of #1564 (needed to update curl which needed to update openssl), but I wasn't able to update everything. As rust-lang/rust#24873 just landed as well tonight's nightly should be the next available which can build Cargo!

@tamird
Copy link
Contributor

tamird commented Apr 30, 2015

This is probably ready for a rebase now

@bors bors merged commit e4ae24b into rust-lang:master May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants