fix(package): Ensure we can package directories ending with '.rs' #15240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might have also broken dependencies whose path ends with `.rs` as well This broke in rust-lang#14961
rustbot
added
A-manifest
epage
added
the
regression-from-stable-to-beta
|
Should we do a beta backport? |
If we want to be extra cautious, yes, though I cannot find a way to break any stable features. |
|
Confirmed: this is visible with stable behavior. $ cargo new foo --lib
$ mv foo foo.rs
$ cargo add --path foo.rs
$ cargo check
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
$ cargo +nightly check
error: failed to get `foo` as a dependency of package `cargo-15240 v0.1.0 (/home/epage/src/personal/dump/cargo-15240)`
Caused by:
failed to load source for dependency `foo`
Caused by:
Unable to update /home/epage/src/personal/dump/cargo-15240/foo.rs
Caused by:
Single file packages cannot be used as dependencies
$ nargo check
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s |
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Mar 1, 2025
…st-lang#15240) ### What does this PR try to resolve? This likely only affects `-Zpackage-workspace` but it might have also broken dependencies whose path ends with `.rs` as well This broke in rust-lang#14961 ### How should we test and review this PR? ### Additional information
|
Beta backport submitted: #15248 |
epage
added a commit
that referenced
this pull request
Mar 1, 2025
Beta backports * #15240 In order to make CI pass, the following PRs are also cherry-picked: *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This likely only affects
-Zpackage-workspacebut it might have also broken dependencies whose path ends with.rsaswell
This broke in #14961
How should we test and review this PR?
Additional information