Skip to content

[DO NOT MERGE] Migrate to edition 2024 #15156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] Migrate to edition 2024 #15156

wants to merge 3 commits into from

Conversation

weihanglo
Copy link
Member

Just want to see how smooth the edition 2024 migration is in cargo repo.
It seems like

  • Most of the changes are if-let rescope. Among those, almost none of them are necessary.
  • Some are new lifetime use<_> capture changes.
  • Some are macro expr_2021 but seems unnecessary for our use cases.

I wouldn't say the migration experience was good, as I needed to really looking into each case to determine whether to keep (haven't done it yet in this PR). Yet, I didn't encounter any compilation error and the main testsuite has passed. The experience could be better if it can auto-detect whether an if-let rescope is needed.

@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts A-cfg-expr Area: Platform cfg expressions A-cli Area: Command-line interface, option parsing, etc. A-configuration Area: cargo config files and env vars A-credential-provider Area: credential provider for storing and retreiving credentials A-dep-info Area: dep-info, .d files A-dependency-resolution Area: dependency resolution and the resolver A-git Area: anything dealing with git A-interacts-with-crates.io Area: interaction with registries A-manifest Area: Cargo.toml issues A-networking Area: networking issues, curl, etc. A-rebuild-detection Area: rebuild detection and fingerprinting A-registries Area: registries A-testing-cargo-itself Area: cargo's tests A-timings Area: timings A-unstable Area: nightly unstable support A-vcs Area: general VCS issues A-workspaces Area: workspaces Command-add Command-build Command-fix Command-install Command-publish Command-remove labels Feb 8, 2025
@rustbot rustbot added Command-update Command-vendor S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2025
@weihanglo weihanglo closed this Feb 8, 2025
@weihanglo weihanglo deleted the edition2024 branch February 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts A-cfg-expr Area: Platform cfg expressions A-cli Area: Command-line interface, option parsing, etc. A-configuration Area: cargo config files and env vars A-credential-provider Area: credential provider for storing and retreiving credentials A-dep-info Area: dep-info, .d files A-dependency-resolution Area: dependency resolution and the resolver A-git Area: anything dealing with git A-interacts-with-crates.io Area: interaction with registries A-manifest Area: Cargo.toml issues A-networking Area: networking issues, curl, etc. A-rebuild-detection Area: rebuild detection and fingerprinting A-registries Area: registries A-testing-cargo-itself Area: cargo's tests A-timings Area: timings A-unstable Area: nightly unstable support A-vcs Area: general VCS issues A-workspaces Area: workspaces Command-add Command-build Command-fix Command-install Command-publish Command-remove Command-update Command-vendor S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weihanglo @rustbot @epage