Update release information for home 0.5.11 #14939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users should be using the standard library `home_dir` instead of this crate.
rustbot
added
A-environment-variables
weihanglo
approved these changes
Dec 15, 2024
Saw this. Assume you are going to release older versions. I am going to merge this now. Thanks! |
github-merge-queue bot
pushed a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Dec 17, 2024
## Description Seeing preview build failures across the board. Looks like `home@0.5.11` was [released a few hours ago](rust-lang/cargo#14939) and comes with a new MSRV of 1.81. We don't have a lockfile for `smithy-rs-tool-common` for some reason. This PR adds one. ``` ~/sandbox/rs/smithy-rs/tools/ci-build/smithy-rs-tool-common on main ✗ [41d648d] 12:14 > cargo check error: rustc 1.78.0 is not supported by the following package: home@0.5.11 requires rustc 1.81 Either upgrade rustc or select compatible dependency versions with `cargo update <name>@<current-ver> --precise <compatible-ver>` where `<compatible-ver>` is the latest version supporting rustc 1.78.0 ``` Added a lockfile and downgraded `home`: ```sh > cargo update home@0.5.11 --precise 0.5.9 ``` ## Testing Build locally + CI. ## Questions Lockfiles do not appear to be updated automatically for anything under `ci-build` unless I'm missing something. This is probably fine as our use of lockfiles is intended to catch issues with consumers of `smithy-rs` and the SDK not our own internal tooling. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: Zelda Hessler <zhessler@amazon.com>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2024
Update cargo 6 commits in 769f622e12db0001431d8ae36d1093fb8727c5d9..99dff6d77db779716dda9ca3b29c26addd02c1be 2024-12-14 04:27:35 +0000 to 2024-12-18 00:55:17 +0000 - fix(build-std): make Resolve align to what to build (rust-lang/cargo#14938) - test(build-std): Isolate output test to avoid spurious `[BLOCKING]` messages from concurrent runs (rust-lang/cargo#14943) - docs: fix wrong changelog PR link (rust-lang/cargo#14947) - docs(unstable): Correct stabilization version for MSRV-resolver (rust-lang/cargo#14945) - Update release information for home 0.5.11 (rust-lang/cargo#14939) - Limit release trigger to 0.* tags (rust-lang/cargo#14940)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to publish a new release of the home crate (from the current master branch).