Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clone-on-write when needed for InternedString #14808

Merged
merged 1 commit into from
Nov 11, 2024
Merged

refactor: clone-on-write when needed for InternedString #14808

merged 1 commit into from
Nov 11, 2024

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Use Cow instead of duplicating the interning logic.

Closes #14674

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2024
@epage epage added this pull request to the merge queue Nov 11, 2024
Merged via the queue into rust-lang:master with commit 2bdeb60 Nov 11, 2024
20 checks passed
@weihanglo weihanglo deleted the cow branch November 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees

@epage epage

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weihanglo @rustbot @epage