test: Migrate publish snapshotting to snapbox #14642
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
A-testing-cargo-itself
epage
force-pushed
the
test-publish
branch
3 times, most recently
from
c094a02
to
103c823
Compare
epage
force-pushed
the
test-publish
branch
2 times, most recently
from
40a0b4f
to
bc62483
Compare
| } | ||
| } | ||
|
|
||
| macro_rules! impl_from_tuple_for_dirsnapshot { |
There was a problem hiding this comment.
I know it is working, and I understand it is for supporting up to 9 tuples (right?). However the macro is a bit hard to read for me. Is this a de-facto decl macro pattern? Is it possible to document what it is doing?
There was a problem hiding this comment.
I've added some comments
There was a problem hiding this comment.
Thanks!
r=me when the version bump is fixed
|
@bors r=weihanglo |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Update cargo 7 commits in 8c30ce53688e25f7e9d860b33cc914fb2957ca9a..cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5 2024-10-15 16:43:16 +0000 to 2024-10-18 13:56:15 +0000 - feat: Stabilize MSRV-aware resolver config (rust-lang/cargo#14639) - Help with `[patch.crates.io]` (rust-lang/cargo#14700) - test: Migrate publish snapshotting to snapbox (rust-lang/cargo#14642) - Bump to 0.85.0; update changelog (rust-lang/cargo#14695) - Fix typo in faq.md (rust-lang/cargo#14696) - fix(registry): `HttpRegistry` `block_until_ready` returns early when work is still pending (rust-lang/cargo#14694) - fix(resolver): avoid cloning when iterating using RcVecIter (rust-lang/cargo#14690)
What does this PR try to resolve?
This is part of #14039 and allows snapshotting in more places.
How should we test and review this PR?
Additional information
InMemoryDiris taken from some experiments I've been doing in snapshot for filesystem assertions. That got held up because of design complexity but publish validation's needs are simpler than I was designing for.