Skip to content

chore(ci): Don't check cargo against beta channel #13827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore(ci): Don't check cargo against beta channel #13827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions crates/xtask-bump-check/src/xtask.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,19 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?;
let status = |msg: &str| gctx.shell().status(STATUS, msg);

// Don't check against beta and stable branches,
// as the publish of these crates are not tied with Rust release process.
// See `TO_PUBLISH` in publish.py.
let crates_not_check_against_channels = ["home"];
let crates_not_check_against_channels = [
// High false positive rate between beta branch and requisite version bump soon after
//
// Low risk because we always bump the "major" version after beta branch; we are
// only losing out on checks for patch releases.
//
// Note: this is already skipped in `changed`
"cargo",
// Don't check against beta and stable branches,
// as the publish of these crates are not tied with Rust release process.
// See `TO_PUBLISH` in publish.py.
"home",
];

status(&format!("base commit `{}`", base_commit.id()))?;
status(&format!("head commit `{}`", head_commit.id()))?;
Expand Down