Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta-1.78] Do not strip debuginfo by default for MSVC #13653

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[beta-1.78] Do not strip debuginfo by default for MSVC #13653

merged 1 commit into from
Mar 26, 2024

Conversation

weihanglo
Copy link
Member

Beta backports:

In order to make CI pass, the following PRs are also cherry-picked:

@weihanglo @Kobzol
Do not strip debuginfo by default for MSVC
fbf8b9f 
Co-authored-by: Jakub Beránek <berykubik@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.78.0. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2024
@epage
Copy link
Contributor

epage commented Mar 26, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2024

📌 Commit fbf8b9f has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024
@bors
Copy link
Contributor

bors commented Mar 26, 2024

⌛ Testing commit fbf8b9f with merge 54d8815...

@bors
Copy link
Contributor

bors commented Mar 26, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing 54d8815 to rust-1.78.0...

@bors bors merged commit 54d8815 into rust-lang:rust-1.78.0 Mar 26, 2024
21 checks passed
@weihanglo weihanglo mentioned this pull request Mar 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2024
@bors
Auto merge of rust-lang#123117 - weihanglo:update-beta-cargo, r=weiha…
595e03f 
…nglo

[beta-1.78] Update cargo

2 commits in 2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b..54d8815d04fa3816edc207bbc4dd36bf18014dbc
2024-03-15 21:39:18 +0000 to 2024-03-26 18:23:22 +0000
- [beta-1.78] Do not strip debuginfo by default for MSVC (rust-lang/cargo#13653)
- [beta 1.78] Fix publish script due to crates.io CDN change (rust-lang/cargo#13616)

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2024
@bors
Auto merge of rust-lang#123117 - weihanglo:update-beta-cargo, r=weiha…
4147533 
…nglo

[beta-1.78] Update cargo

2 commits in 2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b..54d8815d04fa3816edc207bbc4dd36bf18014dbc
2024-03-15 21:39:18 +0000 to 2024-03-26 18:23:22 +0000
- [beta-1.78] Do not strip debuginfo by default for MSVC (rust-lang/cargo#13653)
- [beta 1.78] Fix publish script due to crates.io CDN change (rust-lang/cargo#13616)

r? ghost
@rustbot rustbot added this to the 1.78.0 milestone Mar 27, 2024
@weihanglo weihanglo deleted the rust-1.78.0-backport branch March 29, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@weihanglo @rustbot @epage @bors @ehuss