Stop using UncanonicalizedIter for QueryKind::Exact #11937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryKind::Exact
causes unnecessary HTTP requests when querying for crates that don't exist. Even though the query isExact
, when fetchingSummaries
, Cargo still usesUncanonicalizedIter
and requests additional possible crate names if the first one isn't found.This change moves the use of
UncanonicalizedIter
further up the call stack such that we have theQueryKind
available, and only do the additional queries forQueryKind::Fuzzy
.The impact is most noticeable when publishing a new crate that contains
-
or_
. Since Cargo waits for publish by querying the registry, if the crate name ismy-example-test-crate
, Cargo currently makes 8 HTTP requests each second while waiting for the crate to be available. With this fix, Cargo makes only 1 request per second.cc #11934