Don't query permutations of the path prefix. #11936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the use of the
UncanonicalizedIter
to not create permutations that are not valid paths if the crate has a dash or underscore in the first four characters of the name.Previously it was permuting the path in the prefix, creating invalid paths. For example,
my-tool
would create a path likemy/_t/my-tool
which isn't valid since the filename doesn't match the prefix directories.This fixes it so that it permutes just the name, and then generates the index path after permuting it.
The test included here goes from 16 queries to just 4 queries.
Fixes #11935