Skip to content

Print executable name on cargo test --no-run #2 #10346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2022
Merged

Print executable name on cargo test --no-run #2 #10346

merged 6 commits into from
Feb 20, 2022

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Jan 31, 2022

Closes #9957

This is a continuation of #9959.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2022
@yerke
Copy link
Contributor Author

yerke commented Jan 31, 2022

r? @ehuss

@rust-highfive rust-highfive assigned ehuss and unassigned alexcrichton Jan 31, 2022
@yerke yerke force-pushed the yerke/no-run-test-executable-path branch from 7e99086 to ed579b6 Compare January 31, 2022 18:37
@ehuss
Copy link
Contributor

ehuss commented Feb 1, 2022

This is marked as a draft, is there some additional work you want to do?

@yerke
Copy link
Contributor Author

yerke commented Feb 1, 2022

@ehuss Yes, you mentioned that you wanted benches to be displayed differently in the other PR. I want to get to that shortly.
I have another question for you. Do you want this functionality (naming executables) to work in verbose mode too? I don’t think it does right now.

@yerke yerke marked this pull request as ready for review February 2, 2022 16:20
yerke
yerke commented Feb 2, 2022
View reviewed changes
src/cargo/ops/cargo_test.rs
script_meta: &Option<Metadata>,
test_args: &[&str],
compilation: &Compilation<'_>,
exec_type: &str,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehuss Let me know if you want this to be an enum.

@ehuss
Copy link
Contributor

ehuss commented Feb 20, 2022

Thanks, looks great!

FCP finished in #9959 (comment).

@bors r+

@bors
Copy link
Contributor

bors commented Feb 20, 2022

📌 Commit 0b74ea2 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2022
@bors
Copy link
Contributor

bors commented Feb 20, 2022

⌛ Testing commit 0b74ea2 with merge 46c9b51...

@bors
Copy link
Contributor

bors commented Feb 20, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 46c9b51 to master...

@bors bors merged commit 46c9b51 into rust-lang:master Feb 20, 2022
@yerke yerke deleted the yerke/no-run-test-executable-path branch February 20, 2022 16:32
@bors bors mentioned this pull request Feb 20, 2022
Closed
@ehuss ehuss mentioned this pull request Feb 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2022
@bors
Auto merge of rust-lang#94277 - ehuss:update-cargo, r=ehuss
c651ba8 
Update cargo

8 commits in ea2a21c994ca1e4d4c49412827b3cf4dcb158b1d..d6cdde584a1f15ea086bae922e20fd27f7165431
2022-02-15 04:24:07 +0000 to 2022-02-22 19:55:51 +0000
- Add common profile validation. (rust-lang/cargo#10411)
- Add -Z check-cfg-features to enable compile-time checking of features (rust-lang/cargo#10408)
- Remove invalid target-specific dependency example. (rust-lang/cargo#10401)
- Fix errors in `cargo fetch` usage guide (rust-lang/cargo#10398)
- Fix some broken doc links. (rust-lang/cargo#10404)
- Implement "artifact dependencies" (RFC-3028) (rust-lang/cargo#9992)
- Print executable name on cargo test --no-run rust-lang/cargo#2 (rust-lang/cargo#10346)
- Avoid new deprecation warnings from clap 3.1.0 (rust-lang/cargo#10396)
@ehuss ehuss added this to the 1.61.0 milestone Feb 24, 2022
@ehuss ehuss mentioned this pull request Mar 10, 2022
Merged
@weihanglo weihanglo mentioned this pull request May 21, 2022
Closed
@cchharris cchharris mentioned this pull request Aug 11, 2022
Open
@juliusl juliusl mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

cargo test --no-run should print the resulting binary name
6 participants
@yerke @rust-highfive @ehuss @bors @alexcrichton @vrongmeal