Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/cargo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7fbbf4e8f23e3c24b8afff541dcb17e53eb5ff88
Choose a base ref
...
head repository: rust-lang/cargo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6c1bc24b8b49d4bc965f67d7037906dc199c72b7
Choose a head ref
  • 14 commits
  • 29 files changed
  • 5 contributors

Commits on Oct 21, 2021

  1. Only canonicalize executable path if it has relative directories

    Otherwise symbolic links may also accidentally be resolved which may
    lead to unexpected results in the case of 'coreutils', a binary
    that depends on the executable name being a symbolic link.
    
    This means a path like /bin/echo being canonicalized to /bin/coreutils
    will loose all information about the desired functionality.
    
    Test failures will occur if 'echo' is resolved that way and it's
    not trivial to find the cause of it in the provided error messages.
    Byron committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0d06193 View commit details
    Browse the repository at this point in the history
  2. Assure the binary name won't change after canonicalization, and keep …

    …looking if it does.
    Byron committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    4906ef2 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Bump to 0.59.0

    ehuss committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    8811750 View commit details
    Browse the repository at this point in the history
  2. Update changelog for 1.57

    ehuss committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    333ee58 View commit details
    Browse the repository at this point in the history
  3. Auto merge of #9998 - ehuss:version-bump, r=alexcrichton

    Bump to 0.59.0, update changelog
    bors committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    50a0af4 View commit details
    Browse the repository at this point in the history
  4. Upgrade Cargo to the 2021 edition

    This didn't actually result in any code changes yet, for now this simply
    flips the edition flag for all of our crates and documentation.
    alexcrichton committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    cabe1cc View commit details
    Browse the repository at this point in the history
  5. Remove authors directives from Cargo crates

    Most of these are pretty dated and Cargo defaults nowadays to not
    emitting an `authors` field so this commit also removes them from the
    manifests.
    alexcrichton committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c687d83 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ac69b05 View commit details
    Browse the repository at this point in the history
  7. Fix CI testing

    alexcrichton committed Oct 22, 2021
    1 Configuration menu
    Copy the full SHA
    cab1e35 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. Do not canonicalize the exe-candidate at all

    And here is why: #9991 (comment)
    Byron committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    cf8e464 View commit details
    Browse the repository at this point in the history
  2. Auto merge of #9991 - Byron:fix-test-failure-due-to-echo-resolution, …

    …r=joshtriplett
    
    Don't canonicalize executable path
    
    Otherwise symbolic links may also accidentally be resolved which may lead to unexpected results in the case of 'coreutils', a binary that depends on the executable name being a symbolic link.
    
    This means a path like /bin/echo being canonicalized to /bin/coreutils will loose all information about the desired functionality.
    
    For example, test failures will occur if 'echo' is resolved that way and it's not trivial to find the cause of it in the provided error messages.  For example`doc_workspace_open_different_library_and_package_names` did fail for me on MacOS, Nix packages in PATH, but works with this patch.
    
    With this patch, there is still the possibility that a path gets canonicalized for its relative path components, but still results in changing the name of the binary. I could imagine to check for binary name changes and panic if `coreutils` or `busybox` is encountered, which are known to fail without a symlink telling them which program to emulate.
    bors committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    e165bc8 View commit details
    Browse the repository at this point in the history
  3. Auto merge of #10000 - alexcrichton:upgrade-edition, r=Eh2406

    Upgrade Cargo to the 2021 edition
    
    While I was poking around in the manifests I also went ahead and removed the `authors` entries since at least the one for Cargo itself is quite outdated and Cargo otherwise doesn't use these any more.
    bors committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    dc6a1d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. fix a clippy warning

    TaKO8Ki committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    c3eab8d View commit details
    Browse the repository at this point in the history
  2. Auto merge of #10002 - TaKO8Ki:fix-clippy-warnings, r=ehuss

    Fix a clippy warning
    
    This pull request fixes a clippy warning.
    bors committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    6c1bc24 View commit details
    Browse the repository at this point in the history
Loading