-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Comparing changes
Open a pull request
base repository: rust-lang/cargo
base: 7fbbf4e8f23e3c24b8afff541dcb17e53eb5ff88
head repository: rust-lang/cargo
compare: 6c1bc24b8b49d4bc965f67d7037906dc199c72b7
- 14 commits
- 29 files changed
- 5 contributors
Commits on Oct 21, 2021
-
Only canonicalize executable path if it has relative directories
Otherwise symbolic links may also accidentally be resolved which may lead to unexpected results in the case of 'coreutils', a binary that depends on the executable name being a symbolic link. This means a path like /bin/echo being canonicalized to /bin/coreutils will loose all information about the desired functionality. Test failures will occur if 'echo' is resolved that way and it's not trivial to find the cause of it in the provided error messages.
Configuration menu - View commit details
-
Copy full SHA for 0d06193 - Browse repository at this point
Copy the full SHA 0d06193View commit details -
Assure the binary name won't change after canonicalization, and keep …
…looking if it does.
Configuration menu - View commit details
-
Copy full SHA for 4906ef2 - Browse repository at this point
Copy the full SHA 4906ef2View commit details
Commits on Oct 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8811750 - Browse repository at this point
Copy the full SHA 8811750View commit details -
Configuration menu - View commit details
-
Copy full SHA for 333ee58 - Browse repository at this point
Copy the full SHA 333ee58View commit details -
Auto merge of #9998 - ehuss:version-bump, r=alexcrichton
Bump to 0.59.0, update changelog
Configuration menu - View commit details
-
Copy full SHA for 50a0af4 - Browse repository at this point
Copy the full SHA 50a0af4View commit details -
Upgrade Cargo to the 2021 edition
This didn't actually result in any code changes yet, for now this simply flips the edition flag for all of our crates and documentation.
Configuration menu - View commit details
-
Copy full SHA for cabe1cc - Browse repository at this point
Copy the full SHA cabe1ccView commit details -
Remove
authors
directives from Cargo cratesMost of these are pretty dated and Cargo defaults nowadays to not emitting an `authors` field so this commit also removes them from the manifests.
Configuration menu - View commit details
-
Copy full SHA for c687d83 - Browse repository at this point
Copy the full SHA c687d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac69b05 - Browse repository at this point
Copy the full SHA ac69b05View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for cab1e35 - Browse repository at this point
Copy the full SHA cab1e35View commit details
Commits on Oct 23, 2021
-
Do not canonicalize the exe-candidate at all
And here is why: #9991 (comment)
Configuration menu - View commit details
-
Copy full SHA for cf8e464 - Browse repository at this point
Copy the full SHA cf8e464View commit details -
Auto merge of #9991 - Byron:fix-test-failure-due-to-echo-resolution, …
…r=joshtriplett Don't canonicalize executable path Otherwise symbolic links may also accidentally be resolved which may lead to unexpected results in the case of 'coreutils', a binary that depends on the executable name being a symbolic link. This means a path like /bin/echo being canonicalized to /bin/coreutils will loose all information about the desired functionality. For example, test failures will occur if 'echo' is resolved that way and it's not trivial to find the cause of it in the provided error messages. For example`doc_workspace_open_different_library_and_package_names` did fail for me on MacOS, Nix packages in PATH, but works with this patch. With this patch, there is still the possibility that a path gets canonicalized for its relative path components, but still results in changing the name of the binary. I could imagine to check for binary name changes and panic if `coreutils` or `busybox` is encountered, which are known to fail without a symlink telling them which program to emulate.
Configuration menu - View commit details
-
Copy full SHA for e165bc8 - Browse repository at this point
Copy the full SHA e165bc8View commit details -
Auto merge of #10000 - alexcrichton:upgrade-edition, r=Eh2406
Upgrade Cargo to the 2021 edition While I was poking around in the manifests I also went ahead and removed the `authors` entries since at least the one for Cargo itself is quite outdated and Cargo otherwise doesn't use these any more.
Configuration menu - View commit details
-
Copy full SHA for dc6a1d5 - Browse repository at this point
Copy the full SHA dc6a1d5View commit details
Commits on Oct 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c3eab8d - Browse repository at this point
Copy the full SHA c3eab8dView commit details -
Auto merge of #10002 - TaKO8Ki:fix-clippy-warnings, r=ehuss
Fix a clippy warning This pull request fixes a clippy warning.
Configuration menu - View commit details
-
Copy full SHA for 6c1bc24 - Browse repository at this point
Copy the full SHA 6c1bc24View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7fbbf4e8f23e3c24b8afff541dcb17e53eb5ff88...6c1bc24b8b49d4bc965f67d7037906dc199c72b7