feat(completions): complete cargo clean -p with package names

Author: jakobhellermann

src/bin/cargo/commands/clean.rs

@@ -16,7 +16,7 @@ pub fn cli() -> Command {
         .arg_silent_suggestion()
         .arg_package_spec_simple(
             "Package to clean artifacts for",
-            ArgValueCandidates::new(Vec::new), // TODO(completions): implement dynamic completion for `cargo clean -p`
+            ArgValueCandidates::new(get_pkg_name_candidates),
         )
         .arg_release("Whether or not to clean release artifacts")
         .arg_profile("Clean artifacts of the specified profile")

src/cargo/util/command_prelude.rs

@@ -28,7 +28,7 @@ use home::cargo_home_with_cwd;
 use indexmap::IndexSet;
 use itertools::Itertools;
 use semver::Version;
-use std::collections::{HashMap, HashSet};
+use std::collections::{BTreeMap, HashMap, HashSet};
 use std::ffi::{OsStr, OsString};
 use std::path::Path;
 use std::path::PathBuf;
@@ -1445,6 +1445,26 @@ pub fn get_pkg_id_spec_candidates() -> Vec<clap_complete::CompletionCandidate> {
     candidates
 }
 
+pub fn get_pkg_name_candidates() -> Vec<clap_complete::CompletionCandidate> {
+    let packages: BTreeMap<_, _> = get_packages()
+        .unwrap_or_default()
+        .into_iter()
+        .map(|package| {
+            (
+                package.name(),
+                package.manifest().metadata().description.clone(),
+            )
+        })
+        .collect();
+
+    packages
+        .into_iter()
+        .map(|(name, description)| {
+            clap_complete::CompletionCandidate::new(name.as_str()).help(description.map(From::from))
+        })
+        .collect()
+}
+
 fn get_packages() -> CargoResult<Vec<Package>> {
     let gctx = new_gctx_for_completions()?;