feat: Remove test-enabled and make the reviewed changes

Author: Gmin2

src/cargo/util/command_prelude.rs

@@ -1111,50 +1111,53 @@ pub fn get_registry_candidates() -> CargoResult<Vec<clap_complete::CompletionCan
 }
 
 fn get_profile_candidates() -> CargoResult<Vec<clap_complete::CompletionCandidate>> {
+    match get_workspace_profile_candidates() {
+        Ok(candidates) if !candidates.is_empty() => Ok(candidates),
+        // fallback to default profile candidates
+        _ => Ok(default_profile_candidates()),
+    }
+}
+
+fn get_workspace_profile_candidates() -> CargoResult<Vec<clap_complete::CompletionCandidate>> {
     let gctx = new_gctx_for_completions()?;
-    if let Ok(ws) = Workspace::new(&find_root_manifest_for_wd(gctx.cwd())?, &gctx) {
-        if let Ok(profiles) = Profiles::new(&ws, InternedString::new("dev")) {
-            let mut candidates = Vec::new();
-
-            for name in profiles.profile_names() {
-                if let Ok(profile_instance) = Profiles::new(&ws, name) {
-                    let base_profile = profile_instance.base_profile();
-
-                    let mut description = String::from(if base_profile.opt_level.as_str() == "0" {
-                        "unoptimized"
-                    } else {
-                        "optimized"
-                    });
-
-                    if base_profile.debuginfo.is_turned_on() {
-                        description.push_str(" + debuginfo");
-                    }
+    let ws = Workspace::new(&find_root_manifest_for_wd(gctx.cwd())?, &gctx)?;
+    let profiles = Profiles::new(&ws, InternedString::new("dev"))?;
 
-                    if matches!(name.as_str(), "test" | "bench") {
-                        description.push_str(" with tests enabled");
-                    }
+    let mut candidates = Vec::new();
+    for name in profiles.profile_names() {
+        if let Ok(profile_instance) = Profiles::new(&ws, name) {
+            let base_profile = profile_instance.base_profile();
 
-                    candidates.push(
-                        clap_complete::CompletionCandidate::new(name.to_string())
-                            .help(Some(description.into())),
-                    );
-                }
+            let mut description = String::from(if base_profile.opt_level.as_str() == "0" {
+                "unoptimized"
+            } else {
+                "optimized"
+            });
+
+            if base_profile.debuginfo.is_turned_on() {
+                description.push_str(" + debuginfo");
             }
 
-            return Ok(candidates);
+            candidates.push(
+                clap_complete::CompletionCandidate::new(name.to_string())
+                    .help(Some(description.into())),
+            );
         }
     }
 
-    Ok(vec![
+    Ok(candidates)
+}
+
+fn default_profile_candidates() -> Vec<clap_complete::CompletionCandidate> {
+    vec![
         clap_complete::CompletionCandidate::new("dev".to_string())
             .help(Some("unoptimized + debuginfo".into())),
         clap_complete::CompletionCandidate::new("release".to_string())
             .help(Some("optimized".into())),
         clap_complete::CompletionCandidate::new("test".to_string())
-            .help(Some("unoptimized + debuginfo with tests enabled".into())),
-        clap_complete::CompletionCandidate::new("bench".to_string())
-            .help(Some("optimized with tests enabled".into())),
-    ])
+            .help(Some("unoptimized + debuginfo".into())),
+        clap_complete::CompletionCandidate::new("bench".to_string()).help(Some("optimized".into())),
+    ]
 }
 
 fn get_example_candidates() -> Vec<clap_complete::CompletionCandidate> {