From e82e9c19c5dab66656fd848d53b8c3ca64a933b4 Mon Sep 17 00:00:00 2001 From: Eric Huss Date: Fri, 27 Apr 2018 11:23:57 -0700 Subject: [PATCH] Minor style update. --- src/cargo/core/package_id_spec.rs | 2 +- src/cargo/core/profiles.rs | 43 +++++++++++++++++-------------- 2 files changed, 25 insertions(+), 20 deletions(-) diff --git a/src/cargo/core/package_id_spec.rs b/src/cargo/core/package_id_spec.rs index 0eef43800b7..798c746cc5b 100644 --- a/src/cargo/core/package_id_spec.rs +++ b/src/cargo/core/package_id_spec.rs @@ -8,7 +8,7 @@ use core::PackageId; use util::{ToSemver, ToUrl}; use util::errors::{CargoResult, CargoResultExt}; -/// Some or all of the data required to indentify a package: +/// Some or all of the data required to identify a package: /// /// 1. the package name (a `String`, required) /// 2. the package version (a `Version`, optional) diff --git a/src/cargo/core/profiles.rs b/src/cargo/core/profiles.rs index 70d6a1fe5e5..fbca991d68f 100644 --- a/src/cargo/core/profiles.rs +++ b/src/cargo/core/profiles.rs @@ -173,26 +173,31 @@ impl ProfileMaker { } fn validate_packages(&self, shell: &mut Shell, packages: &HashSet<&str>) -> CargoResult<()> { - if let Some(ref toml) = self.toml { - if let Some(ref overrides) = toml.overrides { - for key in overrides.keys().filter(|k| k.as_str() != "*") { - if !packages.contains(key.as_str()) { - let suggestion = packages - .iter() - .map(|p| (lev_distance(key, p), p)) - .filter(|&(d, _)| d < 4) - .min_by_key(|p| p.0) - .map(|p| p.1); - match suggestion { - Some(p) => shell.warn(format!( - "package `{}` for profile override not found\n\nDid you mean `{}`?", - key, p - ))?, - None => shell - .warn(format!("package `{}` for profile override not found", key))?, - }; + let toml = match self.toml { + Some(ref toml) => toml, + None => return Ok(()), + }; + let overrides = match toml.overrides { + Some(ref overrides) => overrides, + None => return Ok(()), + }; + for key in overrides.keys().filter(|k| k.as_str() != "*") { + if !packages.contains(key.as_str()) { + let suggestion = packages + .iter() + .map(|p| (lev_distance(key, p), p)) + .filter(|&(d, _)| d < 4) + .min_by_key(|p| p.0) + .map(|p| p.1); + match suggestion { + Some(p) => shell.warn(format!( + "package `{}` for profile override not found\n\nDid you mean `{}`?", + key, p + ))?, + None => { + shell.warn(format!("package `{}` for profile override not found", key))? } - } + }; } } Ok(())