Auto merge of #12763 - ehuss:custom_bin_target-windows-gnu, r=weihanglo

bors · bors · commit 1f94bf2db8c8 · 2023-10-02T04:12:23.000Z
Disable custom_target::custom_bin_target on windows-gnu The `custom_target::custom_bin_target` test has been crashing frequently in CI on the x86_64-pc-windows-gnu target since the last LLVM 17 update. This disables the test to reduce the disruption in CI. The issue is being tracked in rust-lang/rust#115985.
diff --git a/tests/testsuite/custom_target.rs b/tests/testsuite/custom_target.rs
@@ -116,6 +116,8 @@ fn custom_target_dependency() {
 }
 
 #[cargo_test(nightly, reason = "requires features no_core, lang_items")]
+// This is randomly crashing in lld. See https://github.com/rust-lang/rust/issues/115985
+#[cfg_attr(all(windows, target_env = "gnu"), ignore = "windows-gnu lld crashing")]
 fn custom_bin_target() {
     let p = project()
         .file(

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,8 @@ fn custom_target_dependency() {`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`#[cargo_test(nightly, reason = "requires features no_core, lang_items")]`
	`119`	`+// This is randomly crashing in lld. See https://github.com/rust-lang/rust/issues/115985`
	`120`	`+#[cfg_attr(all(windows, target_env = "gnu"), ignore = "windows-gnu lld crashing")]`
`119`	`121`	`fn custom_bin_target() {`
`120`	`122`	`let p = project()`
`121`	`123`	`.file(`