Add simple test

Author: Kobzol

src/bors/handlers/workflow.rs

@@ -167,10 +167,6 @@ async fn try_complete_build(
         return Ok(());
     }
 
-    let has_failure = checks
-        .iter()
-        .any(|check| matches!(check.status, CheckSuiteStatus::Failure));
-
     let mut workflows = db.get_workflows_for_build(&build).await?;
     workflows.sort_by(|a, b| a.name.cmp(&b.name));
 
@@ -187,7 +183,7 @@ async fn try_complete_build(
     }
 
     let workflow_list = workflows
-        .into_iter()
+        .iter()
         .map(|w| {
             format!(
                 "- [{}]({}) {}",
@@ -203,6 +199,10 @@ async fn try_complete_build(
         .collect::<Vec<_>>()
         .join("\n");
 
+    let has_failure = workflows
+        .iter()
+        .any(|workflow| matches!(workflow.status, WorkflowStatus::Failure));
+
     let (status, trigger) = if has_failure {
         (BuildStatus::Failure, LabelTrigger::TryBuildFailed)
     } else {
@@ -234,7 +234,12 @@ mod tests {
     use crate::bors::handlers::trybuild::TRY_BRANCH_NAME;
     use crate::database::operations::get_all_workflows;
     use crate::database::WorkflowStatus;
-    use crate::tests::mocks::{run_test, Branch, CheckSuite, Workflow, WorkflowEvent};
+    use crate::tests::mocks::{
+        run_test, BorsBuilder, Branch, CheckSuite, TestWorkflowStatus, Workflow, WorkflowEvent,
+        World,
+    };
+    use chrono::Utc;
+    use std::time::Duration;
 
     #[sqlx::test]
     async fn workflow_started_unknown_build(pool: sqlx::PgPool) {
@@ -414,4 +419,39 @@ mod tests {
         })
         .await;
     }
+
+    #[sqlx::test]
+    async fn workflow_finished_too_quickly(pool: sqlx::PgPool) {
+        let world = World::default();
+        world.default_repo().lock().set_config(
+            r#"
+min_ci_time = 10
+"#,
+        );
+        BorsBuilder::new(pool)
+            .world(world)
+            .run_test(|mut tester| async {
+                tester.create_branch(TRY_BRANCH_NAME).expect_suites(1);
+                tester.post_comment("@bors try").await?;
+                tester.expect_comments(1).await;
+
+                tester
+                    .workflow_full(
+                        Workflow::from(tester.try_branch())
+                            .with_end(Utc::now() + Duration::from_secs(1)),
+                        TestWorkflowStatus::Success,
+                    )
+                    .await?;
+                tester
+                    .check_suite(CheckSuite::completed(tester.try_branch()))
+                    .await?;
+
+                insta::assert_snapshot!(tester.get_comment().await?, @r"
+                :broken_heart: Test failed
+                - [Workflow1](https://github.com/workflows/Workflow1/1) :x:
+                ");
+                Ok(tester)
+            })
+            .await;
+    }
 }

src/tests/mocks/workflow.rs

@@ -1,6 +1,7 @@
 use chrono::{DateTime, Utc};
 use octocrab::models::{CheckRunId, RunId, WorkflowId};
 use serde::Serialize;
+use std::time::Duration;
 use url::Url;
 
 use crate::github::GithubRepoName;
@@ -93,6 +94,8 @@ pub struct Workflow {
     pub head_branch: String,
     head_sha: String,
     pub external: bool,
+    start: DateTime<Utc>,
+    end: DateTime<Utc>,
 }
 
 impl Workflow {
@@ -103,6 +106,9 @@ impl Workflow {
         self.external = true;
         self
     }
+    pub fn with_end(self, end: DateTime<Utc>) -> Self {
+        Self { end, ..self }
+    }
 
     fn new(branch: Branch) -> Self {
         Self {
@@ -112,6 +118,8 @@ impl Workflow {
             head_branch: branch.get_name().to_string(),
             head_sha: branch.get_sha().to_string(),
             external: false,
+            start: Utc::now(),
+            end: Utc::now() + Duration::from_secs(60),
         }
     }
 }
@@ -166,8 +174,8 @@ impl From<WorkflowEvent> for GitHubWorkflowEventPayload {
                     WorkflowEventKind::Started => None,
                     WorkflowEventKind::Completed { status } => Some(status),
                 },
-                created_at: Default::default(),
-                updated_at: Default::default(),
+                created_at: workflow.start,
+                updated_at: workflow.end,
                 url: url.clone(),
                 html_url: url.clone(),
                 jobs_url: url.clone(),