Chapter 8 from tech review #4378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll have more edits to match this when I'm going through the tech review comments for chapter 15, but the reference (pun intended) to this section was brought up in feedback for chapter 8.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 3, 2025
Update books ## rust-lang/book 4 commits in 230c68bc1e08f5f3228384a28cc228c81dfbd10d..634724ea85ebb08a542970bf8871ac8b0f77fd15 2025-05-29 13:16:14 UTC to 2025-05-22 21:35:03 UTC - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) ## rust-embedded/book 3 commits in 0b8219ac23a3e09464e4e0166c768cf1c4bba0d5..10fa1e084365f23f24ad0000df541923385b73b6 2025-05-27 18:37:30 UTC to 2025-05-27 18:26:36 UTC - portability: add reference to embedded-hal docs (rust-embedded/book#391) - remove the unused and deprecated `multilingual` field from `book.toml` (rust-embedded/book#388) - Ci upgrade 20250522 (rust-embedded/book#393) ## rust-lang/nomicon 4 commits in c76a20f0d987145dcedf05c5c073ce8d91f2e82a..8b61acfaea822e9ac926190bc8f15791c33336e8 2025-05-26 10:16:09 UTC to 2025-05-23 15:03:00 UTC - Use inline const expression in unchecked-uninit.md (rust-lang/nomicon#492) - Fix code sample output in unchecked-uninit.md (rust-lang/nomicon#491) - Use consistent type parameters in subtyping.md (rust-lang/nomicon#493) - Fix typo in atomics.md (rust-lang/nomicon#494) ## rust-lang/reference 1 commits in 118fd1f1f0854f50e3ae1fe4b64862aad23009ca..8e0f593a30f3b56ddb0908fb7ab9249974e08738 2025-05-31 20:12:39 UTC to 2025-05-31 20:12:39 UTC - Minor fixes to `$crate` behavior (rust-lang/reference#1816) ## rust-lang/rust-by-example 4 commits in c9d151f9147c4808c77f0375ba3fa5d54443cb9e..21f4e32b8b40d36453fae16ec07ad4b857c445b6 2025-05-29 12:45:08 UTC to 2025-05-29 12:44:23 UTC - Update book.toml rename `author` field to `authors` (rust-lang/rust-by-example#1917) - Add example to comment.md to teach how to toggle a whole code block using block comments (rust-lang/rust-by-example#1919) - The example is not meant to be compiled with out passing arguments. (rust-lang/rust-by-example#1930) - added a shorthand for the #[should_panic(expected = "msg") (rust-lang/rust-by-example#1931)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 3, 2025
Update books ## rust-lang/book 4 commits in 230c68bc1e08f5f3228384a28cc228c81dfbd10d..634724ea85ebb08a542970bf8871ac8b0f77fd15 2025-05-29 13:16:14 UTC to 2025-05-22 21:35:03 UTC - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) ## rust-embedded/book 3 commits in 0b8219ac23a3e09464e4e0166c768cf1c4bba0d5..10fa1e084365f23f24ad0000df541923385b73b6 2025-05-27 18:37:30 UTC to 2025-05-27 18:26:36 UTC - portability: add reference to embedded-hal docs (rust-embedded/book#391) - remove the unused and deprecated `multilingual` field from `book.toml` (rust-embedded/book#388) - Ci upgrade 20250522 (rust-embedded/book#393) ## rust-lang/nomicon 4 commits in c76a20f0d987145dcedf05c5c073ce8d91f2e82a..8b61acfaea822e9ac926190bc8f15791c33336e8 2025-05-26 10:16:09 UTC to 2025-05-23 15:03:00 UTC - Use inline const expression in unchecked-uninit.md (rust-lang/nomicon#492) - Fix code sample output in unchecked-uninit.md (rust-lang/nomicon#491) - Use consistent type parameters in subtyping.md (rust-lang/nomicon#493) - Fix typo in atomics.md (rust-lang/nomicon#494) ## rust-lang/reference 1 commits in 118fd1f1f0854f50e3ae1fe4b64862aad23009ca..8e0f593a30f3b56ddb0908fb7ab9249974e08738 2025-05-31 20:12:39 UTC to 2025-05-31 20:12:39 UTC - Minor fixes to `$crate` behavior (rust-lang/reference#1816) ## rust-lang/rust-by-example 4 commits in c9d151f9147c4808c77f0375ba3fa5d54443cb9e..21f4e32b8b40d36453fae16ec07ad4b857c445b6 2025-05-29 12:45:08 UTC to 2025-05-29 12:44:23 UTC - Update book.toml rename `author` field to `authors` (rust-lang/rust-by-example#1917) - Add example to comment.md to teach how to toggle a whole code block using block comments (rust-lang/rust-by-example#1919) - The example is not meant to be compiled with out passing arguments. (rust-lang/rust-by-example#1930) - added a shorthand for the #[should_panic(expected = "msg") (rust-lang/rust-by-example#1931)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 3, 2025
Update books ## rust-lang/book 4 commits in 230c68bc1e08f5f3228384a28cc228c81dfbd10d..634724ea85ebb08a542970bf8871ac8b0f77fd15 2025-05-29 13:16:14 UTC to 2025-05-22 21:35:03 UTC - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) ## rust-embedded/book 3 commits in 0b8219ac23a3e09464e4e0166c768cf1c4bba0d5..10fa1e084365f23f24ad0000df541923385b73b6 2025-05-27 18:37:30 UTC to 2025-05-27 18:26:36 UTC - portability: add reference to embedded-hal docs (rust-embedded/book#391) - remove the unused and deprecated `multilingual` field from `book.toml` (rust-embedded/book#388) - Ci upgrade 20250522 (rust-embedded/book#393) ## rust-lang/nomicon 4 commits in c76a20f0d987145dcedf05c5c073ce8d91f2e82a..8b61acfaea822e9ac926190bc8f15791c33336e8 2025-05-26 10:16:09 UTC to 2025-05-23 15:03:00 UTC - Use inline const expression in unchecked-uninit.md (rust-lang/nomicon#492) - Fix code sample output in unchecked-uninit.md (rust-lang/nomicon#491) - Use consistent type parameters in subtyping.md (rust-lang/nomicon#493) - Fix typo in atomics.md (rust-lang/nomicon#494) ## rust-lang/reference 1 commits in 118fd1f1f0854f50e3ae1fe4b64862aad23009ca..8e0f593a30f3b56ddb0908fb7ab9249974e08738 2025-05-31 20:12:39 UTC to 2025-05-31 20:12:39 UTC - Minor fixes to `$crate` behavior (rust-lang/reference#1816) ## rust-lang/rust-by-example 4 commits in c9d151f9147c4808c77f0375ba3fa5d54443cb9e..21f4e32b8b40d36453fae16ec07ad4b857c445b6 2025-05-29 12:45:08 UTC to 2025-05-29 12:44:23 UTC - Update book.toml rename `author` field to `authors` (rust-lang/rust-by-example#1917) - Add example to comment.md to teach how to toggle a whole code block using block comments (rust-lang/rust-by-example#1919) - The example is not meant to be compiled with out passing arguments. (rust-lang/rust-by-example#1930) - added a shorthand for the #[should_panic(expected = "msg") (rust-lang/rust-by-example#1931)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 3, 2025
Rollup merge of #141923 - rustbot:docs-update, r=ehuss Update books ## rust-lang/book 4 commits in 230c68bc1e08f5f3228384a28cc228c81dfbd10d..634724ea85ebb08a542970bf8871ac8b0f77fd15 2025-05-29 13:16:14 UTC to 2025-05-22 21:35:03 UTC - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) ## rust-embedded/book 3 commits in 0b8219ac23a3e09464e4e0166c768cf1c4bba0d5..10fa1e084365f23f24ad0000df541923385b73b6 2025-05-27 18:37:30 UTC to 2025-05-27 18:26:36 UTC - portability: add reference to embedded-hal docs (rust-embedded/book#391) - remove the unused and deprecated `multilingual` field from `book.toml` (rust-embedded/book#388) - Ci upgrade 20250522 (rust-embedded/book#393) ## rust-lang/nomicon 4 commits in c76a20f0d987145dcedf05c5c073ce8d91f2e82a..8b61acfaea822e9ac926190bc8f15791c33336e8 2025-05-26 10:16:09 UTC to 2025-05-23 15:03:00 UTC - Use inline const expression in unchecked-uninit.md (rust-lang/nomicon#492) - Fix code sample output in unchecked-uninit.md (rust-lang/nomicon#491) - Use consistent type parameters in subtyping.md (rust-lang/nomicon#493) - Fix typo in atomics.md (rust-lang/nomicon#494) ## rust-lang/reference 1 commits in 118fd1f1f0854f50e3ae1fe4b64862aad23009ca..8e0f593a30f3b56ddb0908fb7ab9249974e08738 2025-05-31 20:12:39 UTC to 2025-05-31 20:12:39 UTC - Minor fixes to `$crate` behavior (rust-lang/reference#1816) ## rust-lang/rust-by-example 4 commits in c9d151f9147c4808c77f0375ba3fa5d54443cb9e..21f4e32b8b40d36453fae16ec07ad4b857c445b6 2025-05-29 12:45:08 UTC to 2025-05-29 12:44:23 UTC - Update book.toml rename `author` field to `authors` (rust-lang/rust-by-example#1917) - Add example to comment.md to teach how to toggle a whole code block using block comments (rust-lang/rust-by-example#1919) - The example is not meant to be compiled with out passing arguments. (rust-lang/rust-by-example#1930) - added a shorthand for the #[should_panic(expected = "msg") (rust-lang/rust-by-example#1931)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 21, 2025
Update books ## rust-lang/book 68 commits in 1d7c3e6abec2d5a9bfac798b29b7855b95025426..af415fc6c8a6823dfb4595074f27d5a3e9e2fe49 2025-10-20 14:01:39 UTC to 2025-01-21 22:49:39 UTC - Prepare for renaming of rust-lang/rust default branch (rust-lang/book#4534) - Adding Uzbek translated rust-book repository to the list (rust-lang/book#4387) - I have added Bengali Translation of The Book. (rust-lang/book#4476) - Add+ vietnamese language translate (rust-lang/book#4368) - Appendix B and Appendix D from tech review (rust-lang/book#4466) - Chapter 21 from tech review (rust-lang/book#4464) - Chapter 20 from tech review (rust-lang/book#4460) - Chapter 19 from tech review (rust-lang/book#4446) - Chapter 18 from tech review (rust-lang/book#4445) - Chapter 16 from tech review (rust-lang/book#4438) - WIP ch 17 edits after tech review (rust-lang/book#4319) - Chapter 15 from tech review (rust-lang/book#4433) - Chapter 14 from tech review (rust-lang/book#4423) - Chapter 13 from tech review (rust-lang/book#4421) - Chapter 12 from tech review (rust-lang/book#4410) - Chapter 11 from tech review (rust-lang/book#4391) - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) - Chapter 6 from tech review (rust-lang/book#4370) - Chapter 5 from tech review (rust-lang/book#4359) - Chapter 4 from tech review (rust-lang/book#4358) - Chapter 3 from tech review (rust-lang/book#4353) - Ch01+ch02 after tech review (rust-lang/book#4329) - Ch. 21: call out Chrome multiple-connections issue (rust-lang/book#4297) - Ch. 16: refactor 16-6 to using listing component (rust-lang/book#4295) - Ch. 01: Show how to work offline (rust-lang/book#4294) - Ch. 07: Clarify sentences about `pub use` (rust-lang/book#4293) - Ch. 02: Consistent ordering of `use` statements (rust-lang/book#4292) - Anchors on listings (rust-lang/book#4271) - Ch. 17: another tweak to how we phrase things about sections (rust-lang/book#4288) - Ch. 20: correct listing number (rust-lang/book#4287) - Ch. 10.3: clarify language detail (rust-lang/book#4284) - Ch. 17: minor typos and link reference (rust-lang/book#4286) - Ch. 9: correctly demonstrate privacy with module (rust-lang/book#4282) - Ch. 18: correct discussion of delegation in `Post` methods (rust-lang/book#4281) - Ch. 20: tell folks to see the Reference for more ABI info (rust-lang/book#4165) - Ch 10.1 minor clarifications (rust-lang/book#4256) - Clarified the misunderstanding b/w crates, module, items (rust-lang/book#4232) - Ferris: always show, even when it’s small (rust-lang/book#4280) - Ch. 17: mention `use std::pin::{Pin, pin};` on introduction (rust-lang/book#4279) - Persist printing error, NOT ErrorKind (rust-lang/book#4259) - Typo: "2" should be "2 seconds" (rust-lang/book#4263) - Ch. 17: fix tiny example consistency issue (rust-lang/book#4270) - Bump ring from 0.17.8 to 0.17.13 in /listings/ch17-async-await/listing-17-02 (rust-lang/book#4261) - Bump ring from 0.17.8 to 0.17.14 in /packages/trpl (rust-lang/book#4273) - 2024 Print Edition: updates to Word docs and more fixes to Markdown text (rust-lang/book#4272) - Ch. 10: Make social media discussion generic. (rust-lang/book#4249) - Another Ch. 17 -> 18 fix (rust-lang/book#4247) - Ch. 05: further tweak to wording about `user1` availability (rust-lang/book#4246) - Ch. 02: Fix rand version mistake (from testing) (rust-lang/book#4245) - Ch. 19: Correct the discussion of `fn` type and closures (rust-lang/book#4244) - Edition maintenance: scripting the updates for future work (rust-lang/book#4243) - Ch. 17: fresh-eyes edits (rust-lang/book#4242) - Ch. 17: drop lifetime not required in 2024 Edition (rust-lang/book#4212) - Appendix B, Operators: Replace “member access” with “field access” and “method call”. (rust-lang/book#4240) - Update to Rust 1.85 and 2024 Edition! (rust-lang/book#4241) - Chapter 1: fix 'four things' now that spacing is not emphasized (rust-lang/book#4239) - Fix typos in chapter 17 (rust-lang/book#4238) - NoStarch backports (rust-lang/book#4224) - Fix example for `cargo fix` (rust-lang/book#4226) - Add missing word in ch17-04-streams.md (rust-lang/book#4218) - Fix typo in ch5.3 and in CONTRIBUTING.md (rust-lang/book#4216) - chore: reformat src with dprint (rust-lang/book#4211) - Redirects: get rid of the weird gap in Ch. 20 sections! (rust-lang/book#4209) - Document that `use` is also for `precise capturing` (rust-lang/book#4210) - Ch. 17: NoStarch Edits! (rust-lang/book#4206) ## rust-lang/nomicon 1 commits in 23fc2682f8fcb887f77d0eaabba708809f834c11..60f0b30d8ec1c9eb5c2582f2ec55f1094b0f8c42 2025-10-20 13:05:39 UTC to 2025-10-20 13:05:39 UTC - Fix typo in exception-safety.md (BinaryHeap::sift_up, user-defined and unsafe code separated) (rust-lang/nomicon#504) ## rust-lang/reference 11 commits in 8efb9805686722dba511b7b27281bb6b77d32130..752eab01cebdd6a2d90b53087298844c251859a1 2025-10-16 04:31:58 UTC to 2025-10-06 22:38:53 UTC - Clarify struct pattern binding shorthand (rust-lang/reference#2054) - Follow edition formatting for keywords (rust-lang/reference#2050) - generalise paragraph (rust-lang/reference#2047) - Rework the definitions of the extern ABIs (rust-lang/reference#2003) - Fix grammar of `ConstParam` (rust-lang/reference#2036) - Add a note to patterns.ident.precedent (rust-lang/reference#2022) - Add a description of how the reference is published (rust-lang/reference#2028) - Rearrange the README a little (rust-lang/reference#2029) - Consistently use sentence case (rust-lang/reference#2030) - More clearly define the default abi of an extern block (rust-lang/reference#2001) - fix(css): Correctly specify grammar-literal-bg (rust-lang/reference#2032)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 21, 2025
Rollup merge of #147916 - rustbot:docs-update, r=ehuss Update books ## rust-lang/book 68 commits in 1d7c3e6abec2d5a9bfac798b29b7855b95025426..af415fc6c8a6823dfb4595074f27d5a3e9e2fe49 2025-10-20 14:01:39 UTC to 2025-01-21 22:49:39 UTC - Prepare for renaming of rust-lang/rust default branch (rust-lang/book#4534) - Adding Uzbek translated rust-book repository to the list (rust-lang/book#4387) - I have added Bengali Translation of The Book. (rust-lang/book#4476) - Add+ vietnamese language translate (rust-lang/book#4368) - Appendix B and Appendix D from tech review (rust-lang/book#4466) - Chapter 21 from tech review (rust-lang/book#4464) - Chapter 20 from tech review (rust-lang/book#4460) - Chapter 19 from tech review (rust-lang/book#4446) - Chapter 18 from tech review (rust-lang/book#4445) - Chapter 16 from tech review (rust-lang/book#4438) - WIP ch 17 edits after tech review (rust-lang/book#4319) - Chapter 15 from tech review (rust-lang/book#4433) - Chapter 14 from tech review (rust-lang/book#4423) - Chapter 13 from tech review (rust-lang/book#4421) - Chapter 12 from tech review (rust-lang/book#4410) - Chapter 11 from tech review (rust-lang/book#4391) - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) - Chapter 6 from tech review (rust-lang/book#4370) - Chapter 5 from tech review (rust-lang/book#4359) - Chapter 4 from tech review (rust-lang/book#4358) - Chapter 3 from tech review (rust-lang/book#4353) - Ch01+ch02 after tech review (rust-lang/book#4329) - Ch. 21: call out Chrome multiple-connections issue (rust-lang/book#4297) - Ch. 16: refactor 16-6 to using listing component (rust-lang/book#4295) - Ch. 01: Show how to work offline (rust-lang/book#4294) - Ch. 07: Clarify sentences about `pub use` (rust-lang/book#4293) - Ch. 02: Consistent ordering of `use` statements (rust-lang/book#4292) - Anchors on listings (rust-lang/book#4271) - Ch. 17: another tweak to how we phrase things about sections (rust-lang/book#4288) - Ch. 20: correct listing number (rust-lang/book#4287) - Ch. 10.3: clarify language detail (rust-lang/book#4284) - Ch. 17: minor typos and link reference (rust-lang/book#4286) - Ch. 9: correctly demonstrate privacy with module (rust-lang/book#4282) - Ch. 18: correct discussion of delegation in `Post` methods (rust-lang/book#4281) - Ch. 20: tell folks to see the Reference for more ABI info (rust-lang/book#4165) - Ch 10.1 minor clarifications (rust-lang/book#4256) - Clarified the misunderstanding b/w crates, module, items (rust-lang/book#4232) - Ferris: always show, even when it’s small (rust-lang/book#4280) - Ch. 17: mention `use std::pin::{Pin, pin};` on introduction (rust-lang/book#4279) - Persist printing error, NOT ErrorKind (rust-lang/book#4259) - Typo: "2" should be "2 seconds" (rust-lang/book#4263) - Ch. 17: fix tiny example consistency issue (rust-lang/book#4270) - Bump ring from 0.17.8 to 0.17.13 in /listings/ch17-async-await/listing-17-02 (rust-lang/book#4261) - Bump ring from 0.17.8 to 0.17.14 in /packages/trpl (rust-lang/book#4273) - 2024 Print Edition: updates to Word docs and more fixes to Markdown text (rust-lang/book#4272) - Ch. 10: Make social media discussion generic. (rust-lang/book#4249) - Another Ch. 17 -> 18 fix (rust-lang/book#4247) - Ch. 05: further tweak to wording about `user1` availability (rust-lang/book#4246) - Ch. 02: Fix rand version mistake (from testing) (rust-lang/book#4245) - Ch. 19: Correct the discussion of `fn` type and closures (rust-lang/book#4244) - Edition maintenance: scripting the updates for future work (rust-lang/book#4243) - Ch. 17: fresh-eyes edits (rust-lang/book#4242) - Ch. 17: drop lifetime not required in 2024 Edition (rust-lang/book#4212) - Appendix B, Operators: Replace “member access” with “field access” and “method call”. (rust-lang/book#4240) - Update to Rust 1.85 and 2024 Edition! (rust-lang/book#4241) - Chapter 1: fix 'four things' now that spacing is not emphasized (rust-lang/book#4239) - Fix typos in chapter 17 (rust-lang/book#4238) - NoStarch backports (rust-lang/book#4224) - Fix example for `cargo fix` (rust-lang/book#4226) - Add missing word in ch17-04-streams.md (rust-lang/book#4218) - Fix typo in ch5.3 and in CONTRIBUTING.md (rust-lang/book#4216) - chore: reformat src with dprint (rust-lang/book#4211) - Redirects: get rid of the weird gap in Ch. 20 sections! (rust-lang/book#4209) - Document that `use` is also for `precise capturing` (rust-lang/book#4210) - Ch. 17: NoStarch Edits! (rust-lang/book#4206) ## rust-lang/nomicon 1 commits in 23fc2682f8fcb887f77d0eaabba708809f834c11..60f0b30d8ec1c9eb5c2582f2ec55f1094b0f8c42 2025-10-20 13:05:39 UTC to 2025-10-20 13:05:39 UTC - Fix typo in exception-safety.md (BinaryHeap::sift_up, user-defined and unsafe code separated) (rust-lang/nomicon#504) ## rust-lang/reference 11 commits in 8efb9805686722dba511b7b27281bb6b77d32130..752eab01cebdd6a2d90b53087298844c251859a1 2025-10-16 04:31:58 UTC to 2025-10-06 22:38:53 UTC - Clarify struct pattern binding shorthand (rust-lang/reference#2054) - Follow edition formatting for keywords (rust-lang/reference#2050) - generalise paragraph (rust-lang/reference#2047) - Rework the definitions of the extern ABIs (rust-lang/reference#2003) - Fix grammar of `ConstParam` (rust-lang/reference#2036) - Add a note to patterns.ident.precedent (rust-lang/reference#2022) - Add a description of how the reference is published (rust-lang/reference#2028) - Rearrange the README a little (rust-lang/reference#2029) - Consistently use sentence case (rust-lang/reference#2030) - More clearly define the default abi of an extern block (rust-lang/reference#2001) - fix(css): Correctly specify grammar-literal-bg (rust-lang/reference#2032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.