Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/backtrace-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cbee6bd626522c52825f941cef646e34a0b976ea
Choose a base ref
...
head repository: rust-lang/backtrace-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f178ce311544b06f423119bfb98f2362f2b35974
Choose a head ref
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on May 20, 2019

  1. Correct a comment in coresymbolication dylib handling

    @alexcrichton
    alexcrichton committed May 20, 2019
    Configuration menu
    Copy the full SHA
    53dc53d View commit details
    Browse the repository at this point in the history

  2. Call CSRelease through a destructor 

    Ensures it's called on panics and allows us to simplify control flow a
bit. Additionally correct the signature of `CSRelease` to return `()`
instead of an empty `c_void` enum.
    @alexcrichton
    alexcrichton committed May 20, 2019
    Configuration menu
    Copy the full SHA
    857a340 View commit details
    Browse the repository at this point in the history

  3. Remove duplicate cfg(unix) for selecting gimli 

    It only works on Linux right now which is a subset of `unix`, so no need
to specify both.
    @alexcrichton
    alexcrichton committed May 20, 2019
    Configuration menu
    Copy the full SHA
    5a0fc38 View commit details
    Browse the repository at this point in the history

  4. Use LoadLibraryA instead of LoadLibraryW 

    We're loading an ascii-only name anyway so no need to do utf-16
weirdness.
    @alexcrichton
    alexcrichton committed May 20, 2019
    Configuration menu
    Copy the full SHA
    5c5f66a View commit details
    Browse the repository at this point in the history

  5. Document panic-related caveats 

    Make sure that it's documented that if `cb` ever panics it may abort the
process on some platforms due to restrictions of the C libraries that
we're using.
    @alexcrichton
    alexcrichton committed May 20, 2019
    Configuration menu
    Copy the full SHA
    7ef89a9 View commit details
    Browse the repository at this point in the history

  6. Simplify actual_start_index in Backtrace 

    Try matching on the exact values and otherwise let extra frames sneak
through if they're otherwise not present
    @alexcrichton
    alexcrichton committed May 20, 2019
    Configuration menu
    Copy the full SHA
    f178ce3 View commit details
    Browse the repository at this point in the history
Loading